fix: DomainValidationStatus.FAILED_TO_VERIFY, DevicePostureChecks.include typing, ApplicationGrantsIT CI fix - #1700
Merged
prachi-okta merged 2 commits intoJul 21, 2026
Conversation
…cePostureChecks.include typing - DomainValidationStatus was missing FAILED_TO_VERIFY, a real value the Okta API returns for domain validation responses. Without it, Jackson fell back to UNKNOWN_DEFAULT_OPEN_API and the original value was lost. (OKTA-1226428) - DevicePostureChecks.include had no items type in the spec, so the generator defaulted to List<String> while the real shape is a list of {variableName, value} pairs. Added a DevicePostureCheckMapping schema and typed include as List<DevicePostureCheckMapping>. (OKTA-1221543) Co-Authored-By: Claude Code
…ant as feature-unavailable testGetNonExistentGrantError / testRevokeNonExistentGrantError already had an outer catch acknowledging 500/501 as "OAuth grants not available", but that only covered exceptions thrown outside the inner try/catch. When the grant call itself returned 500 (observed in CI on master post-merge, ApplicationGrantsIT.testGetNonExistentGrantError), it was caught into the local `exception` variable and then failed the "should return 404" assertion instead of being recognized as the same acknowledged case. Apply the same 500/501 check to that inner exception. Co-Authored-By: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s)
DomainValidationStatusmissingFAILED_TO_VERIFYenum constantDevicePostureChecks.includetypedList<String>instead of a proper structured typeDescription
1.
DomainValidationStatusmissingFAILED_TO_VERIFY(P0)The Okta API returns
"validationStatus": "FAILED_TO_VERIFY"in domain responses (e.g.GET /api/v1/domains/{domainId}), but the SDK enum only declaredCOMPLETED,IN_PROGRESS,NOT_STARTED,VERIFIED. Jackson deserialization fell through toUNKNOWN_DEFAULT_OPEN_APIviaREAD_UNKNOWN_ENUM_VALUES_USING_DEFAULT_VALUE, silently losing the original value. Added the missing constant tosrc/swagger/api.yaml.2.
DevicePostureChecks.includetyped asList<String>(P0)DevicePostureChecks.includehad noitemstype in the spec - just anexample- so the generator defaulted toList<String>, while the real API shape is a list of{variableName, value}pairs. Added a newDevicePostureCheckMappingschema and typedincludeasList<DevicePostureCheckMapping>.3. CI fix:
ApplicationGrantsITnon-existent-grant testsObserved on
masterpost-merge (unrelated to #1699's actual changes - a pre-existing latent test bug that CI happened to hit):testGetNonExistentGrantError/testRevokeNonExistentGrantErroralready acknowledge a500/501response as "OAuth grants not available" via an outer catch block, but that only covers exceptions thrown outside the inner try/catch. WhengetScopeConsentGrant/revokeScopeConsentGrantthemselves returned500, the exception was caught into the localexceptionvariable and then failed the "should return 404" assertion instead of being recognized as the same acknowledged case. Applied the same 500/501 check to that inner exception in both tests.Category
Signoff