Revert changes for EmailDomainDNSRecordType schema#521
Merged
Conversation
BinoyOza-okta
commented
Apr 8, 2026
BinoyOza-okta
commented
Contributor
- As per the requirement modification, reverted the changes for EmailDomainDNSRecordType schema to add CAA ENUM value.
…omainDNSRecordType schema to add CAA ENUM value.
aniket-okta
approved these changes
Apr 8, 2026
aniket-okta
left a comment
aniket-okta
left a comment
There was a problem hiding this comment.
Verified and approving.
Code Review: Correctly removes CAA from EmailDomainDNSRecordType enum in both email_domain_dns_record_type.py and openapi/api.yaml. The model and spec are now in sync.
Live API Verification (dotnet-sdk-dcp.oktapreview.com): Confirmed that /api/v1/email-domains only returns TXT and CNAME DNS record types — no CAA. The revert aligns the SDK with actual API behavior.
Scope Check: DNSRecordTypeDomains (custom domains) is unaffected and retains CAA as expected per OKTA-1146219.
Unit Tests: 221 passed; 10 pre-existing failures in test_file_upload_fix.py and test_config_setter.py — unrelated to this change.
LGTM ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.