Skip to content

fix: return the error instead of dereferencing a None response on transport failures #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
somethingnew2-0 wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −0
Open

fix: return the error instead of dereferencing a None response on transport failures #564

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions openapi/templates/api.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,21 @@ class {{classname}}(ApiClient):
response, response_body, error = await self._request_executor.execute(request)
{{/returnType}}

# A transport-level failure (e.g. a dropped/reset connection or a timeout)
# makes execute() return a None response with the error set. Return that
# error before dereferencing response below, otherwise response.status
# raises AttributeError: 'NoneType' object has no attribute 'status'.
if response is None:
{{#returnType}}
if {{returnType}} is Success:
return (None, error)
else:
return (None, None, error)
{{/returnType}}
{{^returnType}}
return (None, error)
{{/returnType}}

if response_body == '' or response.status == 204:
response_data = RESTResponse(response)
resp = ApiResponse(
Expand Down