fix(polymarket-plugin): v0.4.11 — 6 production bugs + integration test suite

[skylavis-sky]

Summary

Fixes 6 bugs identified from a 10-hour production log (onchainos 2.2.2, EOA mode, Polygon 137, 126 total errors). Also introduces the first integration test suite for the plugin. A subsequent commit adds 3 UX fixes from a fresh-install user flow.

Original 6 bugs (v0.4.11)

1. Bug ⚠️ Plugin Review: issues found in cb75b6e #1 — onchainos not found in non-interactive shells

   • Root cause: Command::new("onchainos") relies on PATH, which omits ~/.local/bin in non-interactive shells (cron, Claude Code subprocess)
   • Fix: onchainos_bin() helper probes ~/.local/bin/onchainos directly; falls back to PATH; overridable via POLYMARKET_ONCHAINOS_BIN for tests

2. Bug feat: merge plugin-store-community + PRD optimization #2 — NegRisk redeem not implemented

   • Root cause: redeem returned early with "not supported" for neg_risk: true markets
   • Fix: queries on-chain ERC-1155 balances via get_ctf_balance(), encodes NegRiskAdapter.redeemPositions(bytes32,uint256[]) calldata, broadcasts via onchainos

3. Bug [new-plugin] test-rust-cli v1.0.0 — E2E verification #3 — Stale CLOB API allowance caused spurious re-approvals

   • Root cause: get_balance_allowance (CLOB API) returns cached/MAX_UINT values; treated MAX_UINT as "no approval"
   • Fix: get_usdc_allowance() reads allowance directly via eth_call on Polygon RPC — always current

4. Bug [new-plugin] test-rust-cli v1.0.0 — E2E verification #4 — approve_usdc encoded exact amount, not MAX_UINT

   • Root cause: approve_usdc(amount) set allowance to the exact order size; next trade with pre-existing MAX_UINT triggered unnecessary re-approval
   • Fix: approve_usdc() always approves u128::MAX; no amount parameter

5. Bug [new-plugin] test-rust-cli v1.0.0 #5 — TEE detection unreliable

   • Root cause: TEE env detection used an external HTTP call that failed in restricted network environments
   • Fix: removed unreliable check; onchainos handles TEE context internally

6. Bug [new-plugin] test-rust-cli v1.0.0 #6 — Approve tx timeout hardcoded at 30s

   • Root cause: During Polygon congestion, approve txs take 60–120s; hardcoded 30s timeout caused false "not observed on-chain" errors
   • Fix: 90s default timeout configurable via POLYMARKET_APPROVE_TIMEOUT_SECS

Integration test suite (new)

48 tests across 4 suites. Zero production binary impact (dev-dependencies excluded from release builds).

• Unit tests (16): ABI encoding, decimal_str_to_hex64, calldata selectors, timeout config
• tests/rpc_mocks.rs (10): wiremock HTTP layer — allowance reads (Bug [new-plugin] test-rust-cli v1.0.0 — E2E verification #3), receipt polling (Bug [new-plugin] test-rust-cli v1.0.0 #6), CTF/USDC balance decoding
• tests/subprocess_mocks.rs (6): mock onchainos shell binary via call log — wallet resolution (Bug ⚠️ Plugin Review: issues found in cb75b6e #1), MAX_UINT approve (Bug [new-plugin] test-rust-cli v1.0.0 — E2E verification #4), NegRisk adapter targeting (Bug feat: merge plugin-store-community + PRD optimization #2), ABI structure

UX fixes from fresh-install user flow (Bug A/B/C)

Bug A — quickstart blind to existing on-chain proxy

• Root cause: quickstart read proxy address only from ~/.config/polymarket/creds.json. On a fresh machine or after a reinstall, creds.json doesn't exist yet, so returning users who already ran setup-proxy were incorrectly told they had no proxy and directed to run setup-proxy again.
• Fix: when creds.json has no proxy, fall back to get_existing_proxy(&eoa) which queries the Polygon RPC via debug_traceCall. Returns the proxy address if already deployed; returns None silently on failure.

Bug B — session expiry produced an unactionable error

• Root cause: when the onchainos session expired, get_wallet_address() surfaced a raw subprocess error with no recovery instructions. Users had to know to run onchainos wallet login separately and also clear stale Polymarket credentials.
• Fix: get_wallet_address() detects session expiry (by exit code and stderr keywords) and returns an actionable error message with the exact two commands needed to recover (onchainos wallet login + rm -f ~/.config/polymarket/creds.json), including the ! prefix syntax for Claude Code chat sessions.

Bug C — SKILL.md had no session recovery guidance for the agent

• Root cause: SKILL.md's Proactive Onboarding section had no scripted path for session expiry. When the binary surfaced the new error message, the agent still had no context for how to guide users through recovery.
• Fix: new ## Session Recovery section in SKILL.md with a 3-step scripted flow; onboarding step 1 updated to reference it; new onboarding step 3 added to check for an existing proxy before directing users to setup-proxy.

Files Changed

File	Change
src/onchainos.rs	onchainos_bin() helper; get_usdc_allowance() via eth_call; approve_usdc() MAX_UINT; get_ctf_balance(), negrisk_redeem_positions(), decimal_str_to_hex64() (new); configurable receipt timeout; URL env-var overrides; session-expiry detection with actionable error
src/commands/buy.rs	Replace CLOB allowance with get_usdc_allowance(); approve_usdc() without amount; configurable timeout
src/commands/redeem.rs	NegRisk redeem path (was early-return stub)
src/commands/quickstart.rs	On-chain proxy fallback via get_existing_proxy()
src/config.rs	Urls::polygon_rpc/clob/gamma/data() env-var-overridable accessors for test injection
src/api.rs	Migrate CLOB/Gamma/Data call sites to Urls::{clob,gamma,data}()
src/lib.rs	New [lib] target so integration tests can import crate internals
Cargo.toml	Version 0.4.10 → 0.4.11; [lib] section; wiremock/tempfile dev-deps
tests/common/mod.rs	TestContext (env-var-serialized via tokio::sync::Mutex), response builders, call log helpers
tests/fixtures/mock_onchainos.sh	Shell mock binary recording all invocations as JSON
tests/rpc_mocks.rs	10 RPC-layer integration tests
tests/subprocess_mocks.rs	6 subprocess/calldata integration tests
SKILL.md	NegRisk redeem documented; Session Recovery section; onboarding proxy-check step; version bumped to 0.4.11
CHANGELOG.md	v0.4.11 entry
plugin.yaml	Version 0.4.11

Live Verification

Tested on Polygon mainnet, 2026-04-25, EOA + POLY_PROXY mode, onchainos 2.2.2, polymarket-plugin 0.4.11.

Buy — exercises Bugs #1, #3, #4, #6

$ polymarket-plugin buy --market-id btc-updown-4h-1777104000 --outcome up --amount 2 --confirm

[polymarket] Note: amount adjusted from $2.000000 to $1.530000 to satisfy order divisibility constraints.
[polymarket] Using POLY_PROXY mode — maker: 0x4e8a53d7b904a4835bb8546b7f777f55d44c04e0
{
  "data": {
    "condition_id": "0x64e907c8bed7094f25f266420e3a519a74503d2713026b21fdf835c6b19c7eff",
    "order_id": "0x1abf3e41fe9f17bbe20e5900f62ad000c746cefa195c5848974ad69040faae17",
    "order_type": "GTC",
    "outcome": "up",
    "shares": 3.0,
    "side": "BUY",
    "status": "matched",
    "tx_hashes": ["0x0c3f1aa43011a627e6a26ddec75a5a141d78503811daff0242c3cdb9970a9808"],
    "usdc_amount": 1.53
  },
  "ok": true
}

Redeem --all — exercises Bug #2 (NegRisk.redeemPositions)

8 resolved positions redeemed in sequence, 0 errors. Two confirmed as neg_risk: true via NegRiskAdapter.redeemPositions:

$ polymarket-plugin redeem --all

[polymarket] Found 8 redeemable position(s). Redeeming sequentially...
[polymarket] [1/8] Redeeming: Will Rory McIlroy win the 2026 Masters tournament?
[polymarket] NegRisk redeem: 1200000 total shares across 2 outcomes — submitting NegRiskAdapter.redeemPositions...
[polymarket] NegRisk redeem tx 0x57cb5cc824e49712f0ebbe3010e50dd20c076f662a8eb58b9dc26fa9f3315fc4 — waiting up to 45s for on-chain confirmation...
...
{
  "data": {
    "error_count": 0,
    "redeemed_count": 8,
    "results": [
      { "neg_risk": true,  "question": "Will Rory McIlroy win the 2026 Masters tournament?",   "eoa_tx": "0x57cb5cc824e49712f0ebbe3010e50dd20c076f662a8eb58b9dc26fa9f3315fc4" },
      { "neg_risk": false, "question": "1. FC Heidenheim 1846 vs. 1. FC Union Berlin: O/U 2.5", "eoa_tx": "0x7cb6a14eb8e30b95e93cdd99b5fe9edfea2093b28b42e18b51d03e1004f06529" },
      { "neg_risk": true,  "question": "Will Cameron Young win the 2026 Masters tournament?",   "eoa_tx": "0xf19fcc08b510ce020ff57637279d23ffebcc5f27b5855b53c8d310bc327a3ad0" },
      { "neg_risk": false, "question": "Bitcoin Up or Down - April 13, 8:00PM-12:00AM ET",      "eoa_tx": "0xeb9ae234b9586b6d955e28582906624c4df8c4e70dc0b397e30bbc52db0a87e0" },
      { "neg_risk": false, "question": "Bitcoin Up or Down - April 14, 4:00AM-8:00AM ET",       "proxy_tx": "0x92932a2d4d2cd7c4e955cf5b1a8a417220a76c08ccc3da570b4f57b7bd72520c" },
      { "neg_risk": false, "question": "Spurs vs. Trail Blazers",                                "proxy_tx": "0x925eabe0696a659ff6f7bdd8424da95ad324d71ef52ce6f14cbee0ebde946644" },
      { "neg_risk": false, "question": "Bitcoin Up or Down - April 13, 12:00PM-4:00PM ET",      "proxy_tx": "0x6bd1375948d98d262c5a734aae3b91afc0ff509570a622f00ae6919dc20b3a90" },
      { "neg_risk": false, "question": "Bitcoin Up or Down - April 14, 12:00AM-4:00AM ET",      "proxy_tx": "0x9957ee59726a456813c5009c24d078504be988219e4e8b844e4b17665900f4b8" }
    ]
  },
  "ok": true
}

Checklist

• All 6 production bugs fixed with targeted changes
• 3 UX bugs fixed (proxy detection, session expiry, SKILL.md recovery guidance)
• 48 tests pass (cargo test — 0 failures)
• Binary built from latest source and installed (polymarket-plugin --version → 0.4.11)
• Version consistent across Cargo.toml, Cargo.lock, plugin.yaml, plugin.json, SKILL.md
• No registry or out-of-scope files in diff
• Live end-to-end verification — buy matched on Polygon mainnet; 8 positions redeemed including 2 neg_risk via NegRiskAdapter.redeemPositions (0 errors)

🤖 Generated with Claude Code