Support for the RU date format #46
Conversation
olebedev
left a comment
olebedev
left a comment
There was a problem hiding this comment.
Ah, sorry, the tests seems broken. Please fix the errors.
Happy to have another look, let me know when you're ready.
|
I'm sorry, I corrected the tests |
| // current is Monday | ||
| now := time.Now() |
There was a problem hiding this comment.
I guess this is occasional, right? If so, can you please move it back
There was a problem hiding this comment.
I have restored the changes, although with this version, my tests in zh/casual_date_test are currently not
There was a problem hiding this comment.
It seems that the reversion may have been a mistake, as my tests are not passing in zh/casual_date_test. Could we consider removing the reversion to ensure the tests function
There was a problem hiding this comment.
@rturovtsev I looked into it and found that it is a bug. You can remove this line safely :)
I'm not sure why the original author in PR #30 added this line, but it is this line that fails the test.
The function zh_test.ApplyFixtures uses the time 2022/03/14 00:00:00 UTC as now, but this line uses a new variable that shadows it. We are now in 2024, a leap year, so the result is 86,400 seconds more than "expected" (in the year 2022). 😂
There was a problem hiding this comment.
@rturovtsev, then ca you please remove this line then so all the test are passing.
@RexSkz, thanks for clarification, I was not too sure what is going on on that side of the project. I should have noticed this earlier, my bad.
There was a problem hiding this comment.
@olebedev Hi! Can you tell me if there are plans to create a new release?
There was a problem hiding this comment.
Hi there, no plans whatsoever, but I will roll this change out as a new tag soon-ish, in a matter of one or two days, bear with me.
There was a problem hiding this comment.
3 participants
Add support:
15 января 2024
25 июля
10 февраля 2024 в 9:30
31.12.2023 23:59
31.12.2023