Open
Conversation
Owner
|
Hi. I'm not removing support for older frameworks yet as long as it costs almost nothing to support them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. This pull request makes several changes, so I've summarised the changes for each file below.
netcoreapp3.1and switches tonet8.0,net9.0,net10.0,netstandard2.0,netstandard2.1,net48.Summary for each file:
src/Sandbox/Sandbox.csproj:src\Zstd.Extern\Zstd.Extern.csproj:IsAotCompatiblefor .NET 8.0 and highersrc\ZstdSharp.Benchmark\ZstdSharp.Benchmark.csproj:src\ZstdSharp.Test\ZstdNetSteamingTests.cs:async voidtoasync Testto be compatible with xUnit v3src\ZstdSharp.Test\ZstdSharp.Test.csproj:src\ZstdSharp\CompressionStream.cs:src\ZstdSharp\Unsafe\Bitstream.cs:src\ZstdSharp\Unsafe\HufDecompress.cs:src\ZstdSharp\Unsafe\ZstdDecompressBlock.cs:Thread.VolatileReadwithVolatile.Read(Thread.VolatileReadjust callsVolatile.Read)src\ZstdSharp\ZstdSharp.csproj:IsAotCompatiblefor .NET 8.0 and higherFollowing this pull request, all tests pass for me. Let me know if you disagree with one of the changes made here.
Note: This pull request was hand-written by myself, not created with AI.