Append generate method and append update feature to param method #1
Open
harobed wants to merge 2 commits intoomarqureshi:masterfrom
harobed:master
Open
Append generate method and append update feature to param method #1harobed wants to merge 2 commits intoomarqureshi:masterfrom harobed:master
harobed wants to merge 2 commits intoomarqureshi:masterfrom
harobed:master
Conversation
Owner
|
It's a bit hard to tell what has changed as all the indentation is now different, could you do this without changing the indentation? (I know the indentation is a little broken - but, it makes it hard to see) I'm also not a fan of the word 'generate' - would this not be better named as 'toString'? |
Author
|
I've split my commit in two changeset :
I think it's more easy now to read my patch. I've changed the name from "generate" to "toString". The documentation is updated and the test also. What are your comment ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've added generate url feature to jQuery-URL-Parser.
It's the first version… user can only update param values.
In next version… I'll append other setter.
Regards,
Stephane