Skip to content

Append generate method and append update feature to param method #1

Open
harobed wants to merge 2 commits intoomarqureshi:masterfrom
harobed:master
Open

Append generate method and append update feature to param method #1
harobed wants to merge 2 commits intoomarqureshi:masterfrom
harobed:master

Conversation

@harobed
Copy link
Copy Markdown

@harobed harobed commented Sep 20, 2012

Hi,

I've added generate url feature to jQuery-URL-Parser.
It's the first version… user can only update param values.
In next version… I'll append other setter.

Regards,
Stephane

@omarqureshi
Copy link
Copy Markdown
Owner

It's a bit hard to tell what has changed as all the indentation is now different, could you do this without changing the indentation? (I know the indentation is a little broken - but, it makes it hard to see)

I'm also not a fan of the word 'generate' - would this not be better named as 'toString'?

@harobed
Copy link
Copy Markdown
Author

harobed commented Sep 25, 2012

I've split my commit in two changeset :

I think it's more easy now to read my patch.

I've changed the name from "generate" to "toString".

The documentation is updated and the test also.

What are your comment ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants