Sanitize new pilot .CHR filenames #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mrannanj merged 6 commits into omf2097:master from mrannanj:strtoupper

Apr 15, 2025

Member

mrannanj commented Apr 8, 2025

No description provided.

mrannanj force-pushed the strtoupper branch 2 times, most recently from aa5bb99 to 83a070a Compare

April 8, 2025 22:14

mrannanj requested review from Nopey and Vagabond

April 8, 2025 22:14

mrannanj force-pushed the strtoupper branch from 83a070a to c593473 Compare

April 8, 2025 22:55

Nopey reviewed

View reviewed changes

src/utils/c_string_util.c Outdated Show resolved Hide resolved

Nopey reviewed

View reviewed changes

src/resources/sgmanager.c Outdated Show resolved Hide resolved

Nopey reviewed

View reviewed changes

testing/test_trn.c Outdated Show resolved Hide resolved

mrannanj force-pushed the strtoupper branch from c593473 to 0fa410c Compare

April 9, 2025 01:31

Nopey reviewed

View reviewed changes

src/formats/chr.c Outdated Show resolved Hide resolved

Nopey reviewed

View reviewed changes

src/formats/chr.h Outdated Show resolved Hide resolved

mrannanj force-pushed the strtoupper branch from 0fa410c to 0a21604 Compare

April 9, 2025 01:45

Nopey changed the title ~~Strtoupper~~ Normalize pilot .CHR filenames

mrannanj force-pushed the strtoupper branch 4 times, most recently from 52bccb5 to 6923317 Compare

April 9, 2025 03:22

Nopey reviewed

View reviewed changes

tools/pcxtool/main.c Show resolved Hide resolved

mrannanj force-pushed the strtoupper branch from 6923317 to 4a7d3cb Compare

April 9, 2025 05:08

Nopey reviewed

View reviewed changes

src/resources/pathmanager.c Show resolved Hide resolved

mrannanj force-pushed the strtoupper branch 10 times, most recently from d09d054 to 8f8f002 Compare

April 10, 2025 09:53

mrannanj force-pushed the strtoupper branch 5 times, most recently from 67d7265 to 0b9f4be Compare

April 12, 2025 17:24

mrannanj changed the title ~~Normalize pilot .CHR filenames~~ Sanitize pilot .CHR filenames

mrannanj force-pushed the strtoupper branch 4 times, most recently from ed4600f to 757c798 Compare

April 13, 2025 10:28


          mechlab: Only accept punch as the enter for new pilot name

863ca32

This is to make using special characters that need shift easier.

mrannanj force-pushed the strtoupper branch 2 times, most recently from a5c3dc7 to 21fdff8 Compare

April 15, 2025 00:34

mrannanj changed the title ~~Sanitize pilot .CHR filenames~~ Sanitize new pilot .CHR filenames

mrannanj marked this pull request as ready for review

April 15, 2025 00:34

mrannanj added 4 commits

April 15, 2025 04:10


          utils: Add str_cut_left()

cfb97c2


          utils: Extract file_exists() from pathmanager to io

15340c4


          resources: Use scan_directory_suffix() in sg_count() implementation

f45d84d


          resources: Use scan_directory_suffix() in sg_load_all() implementation

ce7a79b

mrannanj force-pushed the strtoupper branch 5 times, most recently from 8cf1525 to ea868fa Compare

April 15, 2025 04:57


          Sanitize new pilot .CHR save filenames

ae6c577

Replace special characters in save filenames with "_" and uppercase the
letters.

mrannanj force-pushed the strtoupper branch from ea868fa to ae6c577 Compare

April 15, 2025 05:00

mrannanj merged commit 5151de8 into omf2097:master

8 checks passed

mrannanj deleted the strtoupper branch

April 15, 2025 05:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet