Initial commit of Complex multiplication sample. Modified sample.Json to include citests and guid, updated readme and latest code sample#10
Initial commit of Complex multiplication sample. Modified sample.Json to include citests and guid, updated readme and latest code sample#10anjgola merged 5 commits intooneapi-src:masterfrom praveenkk123:master
Conversation
adding complex multiplication sample to the repo
…een.k.kundurthy@intel.com>
pmpeter1
left a comment
pmpeter1
left a comment
There was a problem hiding this comment.
Class naming not consistent: custom_device_selector
It's not good to use the same variable name in a sample for different datatypes.
h.parallel_for(R, [=](id<1> i) {
This might be better as id<1> idx
The dpc_common.hpp source should not be in the directory and should be included from the common location.
It might be better to adopt the output style used by vector-add to show a subset of the inputs and the output they create from the operation like:
[0] (3+4i) * (2+3i) = (-6 + 15i)
| @@ -0,0 +1,8 @@ | |||
| Copyright 2019 Intel Corporation | |||
There was a problem hiding this comment.
Should be 2020 year, or without year at all. It is new file to this repo, so it better to have up-to-date copyrights
| @@ -0,0 +1,42 @@ | |||
| //============================================================== | |||
| // Copyright � 2019 Intel Corporation | |||
There was a problem hiding this comment.
Should be 2020 year, or without year at all. It is new file to this repo, so it better to have up-to-date copyrights
…er, changed the variable of custom_device_selector, updated year in the license file and changed the output format similar to vector-add
…th and updated the source code to use it accordingly
|
@mkitez Okay to merge this? |
mkitez
left a comment
mkitez
left a comment
There was a problem hiding this comment.
CI passed, looks good to merge
5 participants
Initial commit of Complex multiplication sample. Modified sample.Json to include citests and guid, updated readme and latest code sample