Merged
Conversation
Contributor
|
Can we put this as third-party-programs.txt file instead of README. We need to put other landing page information in README. |
mkitez
reviewed
Jul 15, 2020
| @@ -0,0 +1,52 @@ | |||
| //============================================================== | |||
Contributor
There was a problem hiding this comment.
Why are we committing this file here? Isn't it supposed to be inside oneAPI package only?
Contributor
Author
There was a problem hiding this comment.
per request by Swapna, it is for reference only.
| @@ -1,2 +1,2 @@ | |||
| # oneAPI-samples | |||
| oneAPI-samples | |||
Contributor
There was a problem hiding this comment.
Looks like you are changing header to a paragraph, is this intentional?
Contributor
Author
There was a problem hiding this comment.
This is just a place holder, we are working on a readme, so do not approve the merge as of yet
anjgola
approved these changes
Jul 15, 2020
Contributor
anjgola
left a comment
anjgola
left a comment
There was a problem hiding this comment.
LGTM. As long as CI would not be affected by introducing the 'common' folder, we can go ahead and merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.