Changes to FPGA tutorial shannonization to make it more like other tutorials.#553
Merged
mdbtucker merged 32 commits intooneapi-src:masterfrom Jul 6, 2021
Merged
Changes to FPGA tutorial shannonization to make it more like other tutorials.#553mdbtucker merged 32 commits intooneapi-src:masterfrom
mdbtucker merged 32 commits intooneapi-src:masterfrom
Conversation
Signed-off-by: tyoungsc <tanner.young-schultz@intel.com>
Signed-off-by: tyoungsc <tanner.young-schultz@intel.com>
only the first merge unit Changed Shuffle to Partition Updated pictures and README Used existing pipe_array code (instead of using my own) Code cleanup and comments Tested in emulation and reports, doing a HW build now
Slight code cleanup
CMake update Removed line from samples.json that was not necessary Deleted unused files
(to avoid runtime issue)
merge unit, use a bitonic sorter on the input, rather than a simple partition. Updated README and pictures to fit the new design. Addressed Mike's most recent review comments
other tests). Small update to source file to change II target for A10 and fix indenting
mdbtucker
reviewed
Jun 4, 2021
DirectProgramming/DPC++FPGA/Tutorials/DesignPatterns/shannonization/src/shannonization.cpp
Outdated
Show resolved
Hide resolved
mdbtucker
previously approved these changes
Jun 4, 2021
Contributor
mdbtucker
left a comment
mdbtucker
left a comment
There was a problem hiding this comment.
Approving to trigger CI
mdbtucker
previously approved these changes
Jun 4, 2021
Contributor
mdbtucker
left a comment
mdbtucker
left a comment
There was a problem hiding this comment.
Looks good to me, we'll merge after the 2021.3 tag is created
Contributor
|
@tyoungsc the CI failed in Windows because of a long path name. Is there anything we can do about that? |
Improved Merge kernel for case where SORT_WIDTH=1 with shannonization
Variable renaming
Comments
Grammar
Contributor
Author
|
This PR is intended for 2021.3. Can it be relabeled and merged in? |
Renamed main file to main.cpp Used impu namespace in unrolledloop, pipearray, and static_math Renamed static_math.hpp to impu_math.hpp Updated README, Windows VS files, and CMake with these changes
Comments
New FPGA reference design: merge sort
mdbtucker
approved these changes
Jun 28, 2021
Contributor
Author
|
@mdbtucker can this be merged in now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing Sample Changes
Description
Merged the two vcxproj files into one (like all other tutorials), changed one of the A10 II targets, and fixed indenting of a comment block.