moving vector-add to new repo.#7
Merged
JoeOster merged 2 commits intooneapi-src:masterfrom Jul 16, 2020
Merged
Conversation
Signed-off-by: jennifer.l.jiang <jljiang@orcsle165.jf.intel.com>
anjgola
previously approved these changes
Jun 30, 2020
Contributor
Contributor
Author
|
all checks are failed. But could not find the detail on why. |
mkitez
suggested changes
Jul 2, 2020
| {"id": "cpu_usm","build": ["nmake -f Makefile.win build_usm"],"run": ["nmake -f Makefile.win run_usm"],"clean": ["nmake -f Makefile.win clean"]}, | ||
| {"id": "fpga_emu_buffers","build": ["nmake -f Makefile.win.fpga clean","nmake -f Makefile.win.fpga"],"run": ["nmake -f Makefile.win.fpga run"]} | ||
| ] | ||
| } |
Contributor
There was a problem hiding this comment.
The existing configurations are the correct ones in terms of syntax. Please, review them and make required updates if needed.
Contributor
Author
There was a problem hiding this comment.
I'll make the change and resubmit.
Contributor
There was a problem hiding this comment.
@mkitez Jennifer is on vacation, can you help me understand what the required updates are?
Contributor
There was a problem hiding this comment.
@sravanikonda The json field's value in this PR for 'ciTests' is outdated. It is not using the new format specified here : https://github.com/oneapi-src/oneAPI-samples/wiki/sample-json-ci-test-object
JoeOster
suggested changes
Jul 16, 2020
Contributor
Author
|
I've updated the sample.json. please check if it's correct. |
JoeOster
approved these changes
Jul 16, 2020
mkitez
approved these changes
Jul 16, 2020
jimmytwei
pushed a commit
to jimmytwei/oneAPI-samples
that referenced
this pull request
Mar 29, 2023
Changed data type of 'triad_bytes' from int to size_t to prevent an integer overflow
jimmytwei
pushed a commit
that referenced
this pull request
Jun 6, 2025
Sticking to specific tensorflow and pandas version. Modifying some notebook cells to perform generic actions. Using specific commit url when retrieving the pretrained_word_embeddings.py file. Signed-off-by: Mora Jimenez, Kevin <kevin.mora.jimenez@intel.com> Co-authored-by: Mora Jimenez, Kevin <kevin.mora.jimenez@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
moving the latest vector-add to new repo, updated sample.json, added vector-add-usm.vcxproj
Signed-off-by: jennifer