Rendering toolkit openvkl code sample pr by MichaelRoyceCarroll · Pull Request #712 · oneapi-src/oneAPI-samples

MichaelRoyceCarroll · 2021-10-18T22:29:03Z

Adding a New Sample(s)

Description

New sample PR for oneapi rendering toolkit openvkl sample. (library # 3 of 4)
See #697

Checklist

Administrative

Review sample design with the appropriate Domain Expert:
If you have any new dependencies/binaries, inform the oneAPI Code Samples Project Manager: @JoeOster

Code Development

Implement coding guidelines and ensure code quality. see wiki for details
Adhere to readme template
Enforce format via clang-format config file
Adhere to sample.json specification. https://github.com/oneapi-src/oneAPI-samples/wiki/sample-json-specification
Ensure/create CI test configurations for sample (ciTests field) https://github.com/oneapi-src/oneAPI-samples/wiki/sample-json-ci-test-object
Run jsonlint on sample.json to verify json syntax. www.jsonlint.com

Security and Legal

OSPDT Approval (see @JoeOster for assistance)
Compile using the following compiler flags and fix any warnings, the falgs are: "/Wall -Wformat-security -Werror=format-security"
Bandit Scans (Python only)
Virus scan

Review

Review DPC++ code with Paul Peterseon. (GitHub User: pmpeter1)
Review readme with Tom Lenth(@tomlenth) and/or Joe Oster(@JoeOster)
Tested using Dev Cloud when applicable

* Update Makefile * Update Makefile * Update Makefile * Update DCT.hpp * Update intrin_ftz_sample.cpp * Update merge_sort.cpp * Update intrin_double_sample.cpp * Update intrin_dot_sample.cpp * Update DCT.cpp

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

…ed commit) Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Moving README.md content to individual folders

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

…roll/oneAPI-samples into RenderingToolkit

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

…get stuck. It is not too big. Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

praveenkk123

Approve for CI process only

.repo-tools/Docs_Automation/guids.json

RenderingToolkit/README.md

JoeOster · 2021-10-19T15:54:45Z

OSPDT Approved per OSPDT-1015 * All Apache Licensed libraries distributed as part of oneAPI have been approved
opemVKL is part of the oneAPI Rendering Toolkit

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

…e.json Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

…een removed Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

praveenkk123

Approve for CI purposes only

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

…ore README.md from 2 commits prior Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

praveenkk123

Approve for CI

…d unblock CI! Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

praveenkk123

Approve for CI

praveenkk123

Approve for CI

MichaelRoyceCarroll · 2021-10-28T00:33:38Z

@Yury-B Do I need to wrap the macos steps for the shell? bash -c "stepa; stepb; stepc;" kind of setup? Can you please advise? Thanks.

Yury-B · 2021-10-28T20:45:25Z

@Yury-B Do I need to wrap the macos steps for the shell? bash -c "stepa; stepb; stepc;" kind of setup? Can you please advise? Thanks.

pls, see my advice in #PR710

praveenkk123

Approve for CI

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

praveenkk123

Approve for CI

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

MichaelRoyceCarroll · 2021-11-01T22:14:45Z

I'm going to make OSX json runtime variable path explicit... MacOS clearing envs: ${ONEAPI_ROOT}/rkcommon/latest/lib etc.. to be added for sample.json.

MichaelRoyceCarroll · 2021-11-01T22:41:00Z

I think the 9268c23 should unblock. The macos run.

praveenkk123

Approve for CI

* ONSAM-1414 Broken Link in Headers (#685) * Update Makefile * Update Makefile * Update Makefile * Update DCT.hpp * Update intrin_ftz_sample.cpp * Update merge_sort.cpp * Update intrin_double_sample.cpp * Update intrin_dot_sample.cpp * Update DCT.cpp * fix deprecation notice (#682) * initial commit for RenderingToolkit GSG sample proposal * signed inital commit for RenderingToolkit GSG intro samples Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Added generated GUIDS to .repo-tools/Docs_Automation/guids.json (signed commit) Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Update README.md Moving README.md content to individual folders * Order samples folders Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Update README.md * Adding per sample component README.md files Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Update README.md * Adding percomponent LICENSE placeholder files (to be reviewed) Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Adding converted .pfm input file. This file could help users if they get stuck. It is not too big. Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Updating sample.json files per Joseph Oster guidance Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Updates to oidn README.md for linux and macos Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Update README for library requirements Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * New branch for just openvkl sample Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Add description to base README.md Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * removing overlapping content. overlap to RenderingToolkit-ospray branch Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Updates for the embree README.md Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * clang-format for source Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Escape the spaces for CI and get the correct vklExamples.exe in sample.json Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Escape extra quotes for CI in sample.json Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Should be no Release folder for sample.json on macos or lin. It has been removed Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Escape for accurate exe invoke Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * openvkl README updates Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * CMakeLists.txt simplification updates Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Staging files into CI friendly directories. Should have been done before README.md from 2 commits prior Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Update CMakeLists.txt for 03_openvkl_gsg... C linkage errors * CMakeLists.txt updates for variable name consistency Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Update for CMakeLists.txt... thought it was merged before. This should unblock CI! Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Update sample.json * samples.json to match embree env concerns * CMakeLists health updates Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Remvove rkcommon header for not applicable project Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu> * Update sample.json for healthier pathing... CI affect only. Co-authored-by: JoeOster <52936608+JoeOster@users.noreply.github.com> Co-authored-by: ericlars <eric.larson@intel.com>

JoeOster and others added 18 commits September 29, 2021 09:45

ONSAM-1414 Broken Link in Headers (oneapi-src#685)

8e0bdb3

* Update Makefile * Update Makefile * Update Makefile * Update DCT.hpp * Update intrin_ftz_sample.cpp * Update merge_sort.cpp * Update intrin_double_sample.cpp * Update intrin_dot_sample.cpp * Update DCT.cpp

fix deprecation notice (oneapi-src#682)

4bed52e

initial commit for RenderingToolkit GSG sample proposal

b23d63a

signed inital commit for RenderingToolkit GSG intro samples

f0a1b50

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Added generated GUIDS to .repo-tools/Docs_Automation/guids.json (sign…

9fa62ea

…ed commit) Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Update README.md

be21e94

Moving README.md content to individual folders

Order samples folders

78b2bff

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Update README.md

8990739

Adding per sample component README.md files

fb7dcf2

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Merge branch 'RenderingToolkit' of https://github.com/MichaelRoyceCar…

002b232

…roll/oneAPI-samples into RenderingToolkit

Update README.md

d85d358

Adding percomponent LICENSE placeholder files (to be reviewed)

507eb04

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Adding converted .pfm input file. This file could help users if they …

b738b26

…get stuck. It is not too big. Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Updating sample.json files per Joseph Oster guidance

5f91694

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Updates to oidn README.md for linux and macos

a3461c3

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Update README for library requirements

86c8200

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

New branch for just openvkl sample

62eb2ec

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Add description to base README.md

2c05307

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

JoeOster linked an issue Oct 18, 2021 that may be closed by this pull request

Request to Add a oneAPI Sample: Initial Rendering Toolkit sample #697

Closed

MichaelRoyceCarroll changed the base branch from master to development October 18, 2021 23:39

praveenkk123 approved these changes Oct 19, 2021

View reviewed changes

JoeOster suggested changes Oct 19, 2021

View reviewed changes

.repo-tools/Docs_Automation/guids.json Outdated Show resolved Hide resolved

RenderingToolkit/README.md Outdated Show resolved Hide resolved

JoeOster added the OSPDT Approved label Oct 19, 2021

MichaelRoyceCarroll added 6 commits October 19, 2021 14:59

Attempting to merge all .repo-tools/Docs_Automation/guids.json

9c96bd9

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

removing overlapping content. overlap to RenderingToolkit-ospray branch

10b3560

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Updates for the embree README.md

99295b4

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

clang-format for source

09780c3

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Escape the spaces for CI and get the correct vklExamples.exe in sampl…

d1f4f25

…e.json Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Escape extra quotes for CI in sample.json

46f7db2

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

MichaelRoyceCarroll added 2 commits October 21, 2021 17:34

Should be no Release folder for sample.json on macos or lin. It has b…

044ec7a

…een removed Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Escape for accurate exe invoke

be3542b

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

praveenkk123 approved these changes Oct 22, 2021

View reviewed changes

MichaelRoyceCarroll and others added 6 commits October 26, 2021 14:32

openvkl README updates

0785c5d

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

CMakeLists.txt simplification updates

ccabe84

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Staging files into CI friendly directories. Should have been done bef…

f7313b7

…ore README.md from 2 commits prior Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Update CMakeLists.txt for 03_openvkl_gsg... C linkage errors

6672510

CMakeLists.txt updates for variable name consistency

6160fc9

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Fixing CMakeLists for variable consistency

51d0ff4

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

praveenkk123 approved these changes Oct 26, 2021

View reviewed changes

Update for CMakeLists.txt... thought it was merged before. This shoul…

265b495

…d unblock CI! Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

praveenkk123 approved these changes Oct 27, 2021

View reviewed changes

Update sample.json

a60e583

praveenkk123 approved these changes Oct 27, 2021

View reviewed changes

praveenkk123 requested a review from pmpeter1 October 28, 2021 23:12

samples.json to match embree env concerns

bc62f20

praveenkk123 approved these changes Oct 29, 2021

View reviewed changes

CMakeLists health updates

8e861be

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

praveenkk123 approved these changes Nov 1, 2021

View reviewed changes

pmpeter1 approved these changes Nov 1, 2021

View reviewed changes

Remvove rkcommon header for not applicable project

7b6f329

Signed-off-by: Michael R Carroll <michael.carroll@alumni.usc.edu>

Update sample.json for healthier pathing... CI affect only.

9268c23

MichaelRoyceCarroll mentioned this pull request Nov 1, 2021

Rendering toolkit ospray code sample PR #711

Merged

15 tasks

praveenkk123 approved these changes Nov 1, 2021

View reviewed changes

praveenkk123 merged commit b32d5cc into oneapi-src:development Nov 3, 2021

Conversation

MichaelRoyceCarroll commented Oct 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Adding a New Sample(s)

Description

Checklist

Uh oh!

praveenkk123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JoeOster commented Oct 19, 2021

Uh oh!

praveenkk123 left a comment

Choose a reason for hiding this comment

Uh oh!

praveenkk123 left a comment

Choose a reason for hiding this comment

Uh oh!

praveenkk123 left a comment

Choose a reason for hiding this comment

Uh oh!

praveenkk123 left a comment

Choose a reason for hiding this comment

Uh oh!

MichaelRoyceCarroll commented Oct 28, 2021

Uh oh!

Yury-B commented Oct 28, 2021

Uh oh!

praveenkk123 left a comment

Choose a reason for hiding this comment

Uh oh!

praveenkk123 left a comment

Choose a reason for hiding this comment

Uh oh!

MichaelRoyceCarroll commented Nov 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MichaelRoyceCarroll commented Nov 1, 2021

Uh oh!

praveenkk123 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

MichaelRoyceCarroll commented Oct 18, 2021 •

edited

Loading

MichaelRoyceCarroll commented Nov 1, 2021 •

edited

Loading