Correct IntelPython_XGBoost_Performance sample#769
Merged
praveenkk123 merged 4 commits intooneapi-src:developmentfrom Dec 1, 2021
Merged
Correct IntelPython_XGBoost_Performance sample#769praveenkk123 merged 4 commits intooneapi-src:developmentfrom
IntelPython_XGBoost_Performance sample#769praveenkk123 merged 4 commits intooneapi-src:developmentfrom
Conversation
* Update Makefile * Update Makefile * Update Makefile * Update DCT.hpp * Update intrin_ftz_sample.cpp * Update merge_sort.cpp * Update intrin_double_sample.cpp * Update intrin_dot_sample.cpp * Update DCT.cpp
Signed-off-by: Alexander Myskov <alexander.myskov@intel.com>
Contributor
|
Please submit to development branch but not the master branch |
Contributor
Author
@praveenkk123 target branch was changed. |
Contributor
|
This is a minor bug fix, easy push, does not break sample at all. would be good to merge if possible for 2022.1 (just a directory change as noted, it isn't impacting the rest of the sample at all) @louie-tsai @praveenkk123 |
praveenkk123
pushed a commit
that referenced
this pull request
Dec 7, 2021
* ONSAM-1414 Broken Link in Headers (#685) * Update Makefile * Update Makefile * Update Makefile * Update DCT.hpp * Update intrin_ftz_sample.cpp * Update merge_sort.cpp * Update intrin_double_sample.cpp * Update intrin_dot_sample.cpp * Update DCT.cpp * fix deprecation notice (#682) * correct IntelPython_XGBoost_Performance sample Signed-off-by: Alexander Myskov <alexander.myskov@intel.com> Co-authored-by: JoeOster <52936608+JoeOster@users.noreply.github.com> Co-authored-by: ericlars <eric.larson@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Myskov alexander.myskov@intel.com
Existing Sample Changes
Description
openfunction tries to createHIGGS.csv.gzinside of inexistentdatadirectory which leads to error. Fixing it by creation of file inside of sample root directory. Also addedwithstatement foropenfunction in order close opened stream.External Dependencies
List any external dependencies created as a result of this change.
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration