MODIN: fix getting started samples testing in CI#863
MODIN: fix getting started samples testing in CI#863praveenkk123 merged 2 commits intooneapi-src:masterfrom
Conversation
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
|
For some reason, the CI container still can't import |
| "linux": [ | ||
| { | ||
| "env": ["source /opt/intel/oneapi/setvars.sh --force", "conda create -n aikit-modin-test -c intel -c conda-forge matplotlib runipy intel-aikit-modin", "source activate aikit-modin-test"], | ||
| "env": [], |
There was a problem hiding this comment.
For some reason, placing environment setup and the notebook execution in different cells (env and steps) caused the environment wasn't applied (this was indicated by the "Import error: couldn't find 'modin'" error at CI logs).
Combining environment setup steps and the actual notebook execution in a single cell resolved the problem.
|
@praveenkk123 thanks for rerunning! CI is green now |
Signed-off-by: Dmitry Chigarev dmitry.chigarev@intel.com
Existing Sample Changes
Description
This PR is supposed to fix failing CI testing for Modin's getting started samples. The CI flow has been failing due to conda's failures during environment initialization inside the bash script (conda/conda#7980). The CI script was modified as follows to resolve the problem:
conda.shbefore using conda to be able to activate environments inside a bash script (Can't executeconda activatefrom bash script conda/conda#7980).set -eat the beginning of the CI script to ease debugging if something goes wrong.requirements.txtrather than manually listing them.Fixes Jira REIE-1371.
External Dependencies
No external dependencies were added.
Type of change
How Has This Been Tested?
To test the changes locally:
sample.jsoninto a single bash script.