feat: add automatic GitHub issue comment links#228
Merged
Conversation
206cb11 to
93051dd
Compare
818a0e3 to
43a9fe3
Compare
518143e to
4e52d89
Compare
d331fea to
26e8dab
Compare
8803300 to
693754a
Compare
53e8cf4 to
e6b7424
Compare
32811e2 to
e961bf0
Compare
e961bf0 to
1d9d7b3
Compare
781ef60 to
21a7701
Compare
shiftinv
reviewed
Mar 29, 2023
Contributor
There was a problem hiding this comment.
Other fragment types I've seen, that aren't being handled yet:
- Linking to PR comments from file view: https://github.com/onerandomusername/monty-python/pull/234/files/886b69691a644741c0dad0743744a957ebbdabc6#r1150000416
- This doesn't necessarily have a commit hash,
files#r12341234is also possible
- This doesn't necessarily have a commit hash,
- Seems like older PR comments (< mid 2016) use
#discussion-diff-instead ofpullrequestreview-, e.g. python/asyncio#355 (diff)- The link doesn't actually seem to fully work anymore in the gh UI, but the api docs still reference that fragment format
- Linking to the first message of an issue or PR: #228 (comment)
55ba134 to
c4550ad
Compare
Owner
Author
Given the additional handling this requires on /files/ urls I personally don't want to implement this at the moment, but I wouldn't deny a pr to add it.
I can't recreate this, sorry.
Changed... |
ee7b87f to
aef8d6a
Compare
8861da7 to
c6dcf25
Compare
c6dcf25 to
58f24af
Compare
2861548 to
9a238d8
Compare
9a238d8 to
de29f12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on #227, GH-227