refactor: use strings.builder#2036
Merged
Merged
Conversation
Signed-off-by: keeghcet <keeghcet@outlook.com>
There was a problem hiding this comment.
Pull Request Overview
This PR refactors string concatenation in the Oneliner() method to use strings.Builder instead of simple string concatenation for better performance and reduced memory allocations.
- Replaces string concatenation with
strings.Builderfor improved performance - Updates all string append operations to use
WriteString()method - Adds necessary import for the
stringspackage
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
chasefleming
approved these changes
Sep 8, 2025
Member
|
Thanks for improving this! |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #???
Description
The modernize has added an analyzer for using strings.Builder for string construction. strings.Builder has fewer memory allocations and better performance.
More info: golang/go#75190
For contributor use:
masterbranchFiles changedin the Github PR explorer