Update derive events hash test by illia-malachyn · Pull Request #62 · onflow/rosetta

illia-malachyn · 2024-05-27T17:18:54Z

Closes #56

This PR is made on top #53

Summary by CodeRabbit

New Features
- Updated spork configuration to include a new access node and updated root block and version.
Improvements
- Enhanced event and transaction processing with new encoding version for better compatibility and performance.
Bug Fixes
- Improved error handling and logging for event collection processes.
Configuration Updates
- Updated testnet clone configuration with new spork details.

coderabbitai · 2024-05-27T17:19:09Z

Walkthrough

The recent changes introduce an EventEncodingVersion field to several functions in access/access.go, update decoding logic in state/convert.go, and modify test configurations in state/convert_test.go. Additionally, the state/process.go loop handling event hashes has been improved, and the testnet-clone.json file has been updated with new spork configurations. These changes aim to enhance event and transaction processing, improve test reliability, and ensure consistency in spork configurations.

Changes

Files	Change Summary
access/access.go	Added `EventEncodingVersion: entities.EventEncodingVersion_CCF_V0` to various functions to standardize event encoding.
state/convert.go	Updated imports and replaced `jsoncdc.Decode` with `decodePayload` to handle different payload decoding scenarios.
state/convert_test.go	Updated `accessAddr`, `startBlockHeight`, and `endBlockHeight` values, and changed `Version` and `RootBlock` in `createSpork` function.
state/process.go	Modified loop to assign `eventHash` from `eventHashes` and improved error logging for event collection comparison.
testnet-clone.json	Updated `sporks` configuration with new `root_block`, `version`, and added a new address to the `access_nodes` list.

Assessment against linked issues

Objective	Addressed	Explanation
[Rosetta] Fix TestDeriveEventsHash test (#56)	✅

In the code's embrace, events now align,
With hashes derived, in a sequence so fine.
New versions take flight, encoding the tale,
As blocks and transactions through the system sail.
Sporks updated, nodes join the dance,
In the world of Flow, we now enhance.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to full the review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between bab50a2 and 7049b1e.

Files ignored due to path filters (2)

go.mod is excluded by !**/*.mod
go.sum is excluded by !**/*.sum

Files selected for processing (5)

access/access.go (6 hunks)
state/convert.go (3 hunks)
state/convert_test.go (3 hunks)
state/process.go (2 hunks)
testnet-clone.json (1 hunks)

Additional comments not posted (5)

testnet-clone.json (1)

21-28: The updates to the spork configuration look correct and align with the intended changes for spork ID 37.

state/convert_test.go (1)

16-18: The updates to the test configuration parameters and the createSpork function align with the new spork settings and are correctly implemented.

Also applies to: 152-155

state/convert.go (1)

7-9: The introduction of new imports and the decodePayload function enhances the handling of different payload formats, aligning with the new EventEncodingVersion. This is a positive change for maintaining robustness in event data processing.

Also applies to: 207-214

access/access.go (1)

168-170: The inclusion of the EventEncodingVersion field in API calls is correctly implemented and essential for ensuring consistent event data handling across the system.

Also applies to: 390-391, 411-413, 434-435, 460-461, 481-482

state/process.go (1)

Line range hint 307-324: Improved error handling and event hash comparison logic.

The changes made to the event hash comparison logic and the addition of detailed error messages enhance the robustness of the function. This should help in identifying and debugging issues related to event hash mismatches more effectively.

peterargue · 2024-05-27T23:01:17Z

 		}
 		var execResult *entities.ExecutionResult
+
+		//TODO: ILLIA: chunk[0].EventCollection is empty! but should be equal to hash?


is this from the live network?

Sorry, this is obsolete. I removed this comment. I noticed such a behavior only for the root block of a new spork.
Is it expected? You can resolve this thread and merge if so

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7049b1e and ca302e4.

Files selected for processing (1)

state/convert_test.go (2 hunks)

Files skipped from review as they are similar to previous changes (1)

state/convert_test.go

illia-malachyn added 5 commits May 27, 2024 16:44

Requests to access node use CCF encoding from now on

865901f

decode payload via ccf

2fd592f

update root block and spork id

c632ffa

Upgrade go version, flow-go and core-contracts deps

ae4023f

Update mainnet spork info for state indexer's convert test

7049b1e

coderabbitai Bot reviewed May 27, 2024

View reviewed changes

peterargue reviewed May 27, 2024

View reviewed changes

peterargue approved these changes May 27, 2024

View reviewed changes

Remove obsolete todo

ca302e4

coderabbitai Bot reviewed May 28, 2024

View reviewed changes

peterargue merged commit 37cb126 into onflow:main May 28, 2024

coderabbitai Bot mentioned this pull request Sep 9, 2024

Illia malachyn/embed scripts to rosetta #66

Merged

coderabbitai Bot mentioned this pull request Sep 8, 2025

Final malleability changes: ServiceEventCount #90

Merged

Navigation Menu

Uh oh!

Update derive events hash test - #62

Update derive events hash test#62
peterargue merged 6 commits into
onflow:mainfrom
The-K-R-O-K:illia-malachyn/56-update-derive-events-hash-test

illia-malachyn commented May 27, 2024 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 27, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai Bot left a comment

Uh oh!

peterargue May 27, 2024

Uh oh!

illia-malachyn May 28, 2024 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

illia-malachyn commented May 27, 2024 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Assessment against linked issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

peterargue May 27, 2024

Choose a reason for hiding this comment

Uh oh!

illia-malachyn May 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

illia-malachyn commented May 27, 2024 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 27, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)

illia-malachyn May 28, 2024 •

edited

Loading