docs: refresh docs and skills for refactored public API helpers - #337
Merged
Conversation
Performance Comparison
|
justinchuby
added a commit
that referenced
this pull request
Jun 4, 2026
Addresses review feedback on #337: the helper table is introduced as 'mobius._weight_utils centralises...', but _rename_moe_expert_weights is defined in mobius.models.moe, not _weight_utils. Annotate the row so readers import it from the correct module. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Justin Chu <11205048+justinchuby@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Refreshes documentation and agent-skill guidance to match a refactored public API and DRY weight-preprocessing helpers.
Changes:
- Update GGUF docs to import
build_from_gguffrom the top-levelmobiuspackage. - Extend the
weight-name-alignmentskill with a “Shared helpers” section and examples for weight preprocessing. - Update
multimodal-models/moe-modelsskills to reference shared helpers and refreshed Qwen3.5-MoE structure.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/getting-started.md | Updates the GGUF quickstart import path. |
| docs/api/build_from_gguf.md | Updates build_from_gguf import examples. |
| .agents/skills/weight-name-alignment/SKILL.md | Adds a shared-helper table + examples for weight preprocessing. |
| .agents/skills/multimodal-models/SKILL.md | Points multimodal guidance at shared weight helpers. |
| .agents/skills/moe-models/SKILL.md | Refreshes Qwen3.5-MoE class/file references and architectural notes. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Reflect the public-API and DRY changes shipped in PRs #333/#334/#336: - build_from_gguf is now a top-level export; update the import examples in docs/api/build_from_gguf.md and docs/getting-started.md to `from mobius import build_from_gguf`. - weight-name-alignment skill: add a 'Shared helpers' section documenting the _weight_utils rename helpers, including the new rename_weight_keys and vlm_vision_weights, so future model work reuses them instead of hand-written rename loops. - multimodal-models skill: point at the shared vlm_* weight helpers. - moe-models skill: note Qwen35MoEBlock subclasses Qwen2MoELayer and fix the class file paths (models/qwen.py -> models/qwen35.py). Depends on #333 (build_from_gguf export), #334 (rename_weight_keys) and #336 (vlm_vision_weights) landing first. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Justin Chu <11205048+justinchuby@users.noreply.github.com>
Addresses review feedback on #337: the helper table is introduced as 'mobius._weight_utils centralises...', but _rename_moe_expert_weights is defined in mobius.models.moe, not _weight_utils. Annotate the row so readers import it from the correct module. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Justin Chu <11205048+justinchuby@users.noreply.github.com>
justinchuby
force-pushed
the
justinchu/docs-skills-update
branch
from
June 5, 2026 15:39
863f85c to
ef81d1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates outdated docs and agent skills to match the public-API + DRY refactor shipped across the themed PRs.
Changes
build_from_ggufimport — now a top-level export, sodocs/api/build_from_gguf.mdanddocs/getting-started.mdusefrom mobius import build_from_ggufinstead of the internalmobius.integrations.ggufpath._weight_utilsrename helpers, including the newrename_weight_keysandvlm_vision_weights, so future model work reuses them instead of hand-written rename loops.vlm_*weight helpers.Qwen35MoEBlocknow subclassesQwen2MoELayer, and fixes stale class file paths (models/qwen.py→models/qwen35.py).Dependencies
Depends on the API PRs landing first (the helpers/exports documented here only exist on those branches):
build_from_gguftop-level exportrename_weight_keysvlm_vision_weightsDocs-only; no code or tests affected.