Bug Description
`entrypoint.sh` (line 5) passes `$VIRTWORK_ARGS` unquoted to `exec`, which will cause word-splitting on arguments that contain spaces. Additionally, the script does not log the command being executed, making debugging pod startup failures harder in OpenShift.
Steps to Reproduce
- Set `VIRTWORK_ARGS` to a value containing spaces (e.g., `--namespace "my namespace"`)
- Run the entrypoint script
- Observe that the argument is split incorrectly
Expected Behavior
Arguments should be handled correctly regardless of spaces. The script should also:
- Log the command being executed before `exec`
- Validate that `VIRTWORK_COMMAND` is a valid subcommand
Actual Behavior
- Unquoted `$VIRTWORK_ARGS` will word-split incorrectly if values contain spaces
- No logging of the command being executed before `exec`
- No validation that `VIRTWORK_COMMAND` is a valid subcommand
Command
Other
Go Version
Not provided
Deployment Mode
In-cluster pod (deploy/ manifests)
Additional Context
Severity: Low
Files:
- `entrypoint.sh:5` — `exec /usr/local/bin/virtwork $VIRTWORK_COMMAND $VIRTWORK_ARGS`
Note: Quoting `"$VIRTWORK_ARGS"` would treat the entire string as one argument, which is also wrong. The real fix is to use shell array handling or accept that args must be space-delimited simple tokens (and document this constraint).
Bug Description
`entrypoint.sh` (line 5) passes `$VIRTWORK_ARGS` unquoted to `exec`, which will cause word-splitting on arguments that contain spaces. Additionally, the script does not log the command being executed, making debugging pod startup failures harder in OpenShift.
Steps to Reproduce
Expected Behavior
Arguments should be handled correctly regardless of spaces. The script should also:
Actual Behavior
Command
Other
Go Version
Not provided
Deployment Mode
In-cluster pod (deploy/ manifests)
Additional Context
Severity: Low
Files:
Note: Quoting `"$VIRTWORK_ARGS"` would treat the entire string as one argument, which is also wrong. The real fix is to use shell array handling or accept that args must be space-delimited simple tokens (and document this constraint).