Category
Code quality / code smell
Description
Reported by: @OchiengEd
Original issue: #25
The if statement to find env vars prefixed with VIRTWORK_ and to unset them is unnecessarily complex, confusing, and potential maintenance problem in the config test setup.
Severity
Medium — increases maintenance burden or risk of future bugs
Affected Files
internal/config/config_test.go - L42-L49
Proposed Fix
Edmund proposes using strings.HasPrefix and strings.Cut to find env vars prefixed with VIRTWORK_ env vars and the entire env var key to unset
Area
Testing
Architecture Layer
Layer 1 - Infrastructure (config, cluster, cloudinit, audit)
Additional Context
No response
Category
Code quality / code smell
Description
Reported by: @OchiengEd
Original issue: #25
The if statement to find env vars prefixed with VIRTWORK_ and to unset them is unnecessarily complex, confusing, and potential maintenance problem in the config test setup.
Severity
Medium — increases maintenance burden or risk of future bugs
Affected Files
internal/config/config_test.go- L42-L49Proposed Fix
Edmund proposes using strings.HasPrefix and strings.Cut to find env vars prefixed with VIRTWORK_ env vars and the entire env var key to unset
Area
Testing
Architecture Layer
Layer 1 - Infrastructure (config, cluster, cloudinit, audit)
Additional Context
No response