Skip to content

fix(run): propagate registry.Get error in service creation loop #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrhillsman merged 1 commit into from
May 28, 2026
Merged

fix(run): propagate registry.Get error in service creation loop #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/virtwork/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@ func runE(cmd *cobra.Command, args []string) error {
}
w, err := registry.Get(name, wlCfg, registryOpts...)
if err != nil {
continue
return fmt.Errorf("creating workload %q for service check: %w", name, err)
}
if w.RequiresService() {
svc := w.ServiceSpec()
Expand Down
19 changes: 19 additions & 0 deletions cmd/virtwork/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,6 +822,25 @@ var _ = Describe("CLI end-to-end scenarios", func() {
})
})

var _ = Describe("Service creation loop error handling", func() {
It("should return error from registry for unknown workload", func() {
registry := workloads.DefaultRegistry()
cfg := config.WorkloadConfig{
Enabled: config.BoolPtr(true),
VMCount: 1,
CPUCores: constants.DefaultCPUCores,
Memory: constants.DefaultMemory,
}

_, err := registry.Get("nonexistent-workload", cfg,
workloads.WithNamespace(constants.DefaultNamespace),
workloads.WithSSHCredentials(constants.DefaultSSHUser, "", nil),
)
Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("nonexistent-workload"))
})
})

var _ = Describe("DataVolume namespacing for multi-VM deployments", func() {
// nolint: dupl
Context("when deploying multiple VMs of disk workload", func() {
Expand Down
Loading