docs: fix stale references and mental models in development.md#178
Merged
Conversation
Update Go prerequisite from 1.25+ to 1.26+ to match go.mod. Add missing orchestrator/ package to project layout listing. Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
Move audit from Layer 4 to Layer 1 (recording, not orchestration). Add orchestrator to Layer 4 where errgroup concurrency lives. Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
…table DataVolumeTemplates returns ([]DataVolumeTemplateSpec, error), not just nil. ServiceSpec takes no namespace parameter — the actual signature is ServiceSpec() *corev1.Service. Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
Replace stale Roles() []string with RoleDistribution() []RoleSpec. Include RoleSpec type definition showing Role and VMCount fields. Rewrite pattern steps to explain per-role VM counts instead of len(Roles()) multiplication. Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
NamespaceDataVolumes is exported and lives in internal/orchestrator/types.go, not in cmd/virtwork/main.go. Concurrency narrative now correctly attributes errgroup usage to the orchestrator package. Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrhillsman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
exe-prow-github-app
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
orchestrator/package to project structure listingauditto Layer 1, addorchestratorto Layer 4DataVolumeTemplates()signature to show error return; remove phantomnamespaceparam fromServiceSpec()Roles() []stringwithRoleDistribution() []RoleSpecin MultiVMWorkload interface listing and pattern instructionsNamespaceDataVolumespath tointernal/orchestrator/types.goand update concurrency narrative to reference orchestrator packageResolves #177