Skip to content

fix: replace deprecated Running field with RunStrategy in VM spec #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrhillsman merged 1 commit into from
May 21, 2026
Merged

fix: replace deprecated Running field with RunStrategy in VM spec #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/vm/vm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ type VMSpecOpts struct {
// It configures a containerDisk for the OS image, cloudInitNoCloud for userdata,
// masquerade networking, and virtio disk bus.
func BuildVMSpec(opts VMSpecOpts) *kubevirtv1.VirtualMachine {
running := true
runStrategy := kubevirtv1.RunStrategyAlways

disks := []kubevirtv1.Disk{
{
Expand Down Expand Up @@ -109,7 +109,7 @@ func BuildVMSpec(opts VMSpecOpts) *kubevirtv1.VirtualMachine {
Labels: opts.Labels,
},
Spec: kubevirtv1.VirtualMachineSpec{
Running: &running,
RunStrategy: &runStrategy,
Template: &kubevirtv1.VirtualMachineInstanceTemplateSpec{
ObjectMeta: metav1.ObjectMeta{
Labels: opts.Labels,
Expand Down
6 changes: 3 additions & 3 deletions internal/vm/vm_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,9 @@ var _ = Describe("BuildVMSpec", func() {
Expect(memReq.Equal(expected)).To(BeTrue())
})

It("should set running to true", func() {
Expect(result.Spec.Running).NotTo(BeNil())
Expect(*result.Spec.Running).To(BeTrue())
It("should set RunStrategy to Always", func() {
Expect(result.Spec.RunStrategy).NotTo(BeNil())
Expect(*result.Spec.RunStrategy).To(Equal(kubevirtv1.RunStrategyAlways))
})

It("should configure masquerade networking", func() {
Expand Down
Loading