fix: use semantic version tag instead of mutable :latest in deployment#41
Merged
Merged
Conversation
Replace quay.io/opdev/virtwork:latest with v0.0.1 semantic version tag to ensure reproducible deployments. Mutable :latest tag can silently pick up different images between pod restarts, making debugging difficult. Semantic version tags provide: - Reproducible deployments (version tags follow semver conventions) - Human-readable versions vs opaque digests - Easy manual updates during releases - No automation needed to update manifests Changes: - Update deploy/deployment.yaml to use v0.0.1 tag - Change imagePullPolicy from Always to IfNotPresent - Update README.md to document versioned tag usage and upgrade process Fixes #2 Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrhillsman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
exe-prow-github-app
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace quay.io/opdev/virtwork:latest with v0.0.1 semantic version tag to ensure reproducible deployments. Mutable :latest tag can silently pick up different images between pod restarts, making debugging difficult.
Semantic version tags provide:
Changes:
Fixes #2