Skip to content

fix: add validation and logging to entrypoint.sh #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrhillsman merged 1 commit into from
May 21, 2026
Merged

fix: add validation and logging to entrypoint.sh #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,26 @@
#!/bin/sh
set -e

# VIRTWORK_ARGS is intentionally left unquoted to allow space-delimited
# tokenization (e.g., "--workloads cpu,memory --vm-count 2").
# This means argument values CANNOT contain spaces.
# Do not pass: VIRTWORK_ARGS='--namespace "my namespace"'
# Instead use: VIRTWORK_ARGS='--namespace my-namespace'

if [ -n "$VIRTWORK_COMMAND" ]; then
exec /usr/local/bin/virtwork $VIRTWORK_COMMAND $VIRTWORK_ARGS
# Validate command
case "$VIRTWORK_COMMAND" in
run|cleanup)
echo "[entrypoint] Executing: virtwork $VIRTWORK_COMMAND $VIRTWORK_ARGS"
# shellcheck disable=SC2086
exec /usr/local/bin/virtwork "$VIRTWORK_COMMAND" $VIRTWORK_ARGS
;;
*)
echo "[entrypoint] ERROR: Invalid VIRTWORK_COMMAND='$VIRTWORK_COMMAND'. Must be 'run' or 'cleanup'." >&2
exit 1
;;
esac
else
echo "No VIRTWORK_COMMAND set. Pod will sleep. Use 'oc exec' to run virtwork manually."
echo "[entrypoint] No VIRTWORK_COMMAND set. Pod will sleep. Use 'oc exec' to run virtwork manually."
exec sleep infinity
fi
Loading