test: add comprehensive tests for testutil package#44
Merged
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrhillsman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
exe-prow-github-app
Bot
added
the
approved
mrhillsman
force-pushed
the
test/add-testutil-tests
branch
2 times, most recently
from
May 21, 2026 22:32
291e034 to
1a3dc12
Compare
Add unit tests for testutil.go and binary.go functions: - UniqueNamespace: validates format and uniqueness - ManagedLabels: verifies label keys and values - DefaultVMOpts: tests all default VM configuration fields - BinaryPath: tests env var fallback and build caching - RunVirtwork: validates CLI execution with various arguments Add integration tests for cluster-dependent functions: - MustConnect: tests cluster connection and panic behavior - EnsureTestNamespace: validates namespace creation with labels - CleanupNamespace: verifies graceful cleanup handling - WaitForVMRunning: tests timeout behavior Integration tests use //go:build integration tag and require a live cluster. Unit tests achieve 58.2% code coverage. Fixes #14 Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
mrhillsman
force-pushed
the
test/add-testutil-tests
branch
from
May 21, 2026 23:03
1a3dc12 to
a6bd805
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add unit tests for testutil.go and binary.go functions:
Add integration tests for cluster-dependent functions:
Integration tests use //go:build integration tag and require a live cluster. Unit tests achieve 58.2% code coverage.
Fixes #14