Skip to content

fix: stabilize flaky WaitForVMRunning timing assertion #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrhillsman merged 1 commit into from
May 22, 2026
Merged

fix: stabilize flaky WaitForVMRunning timing assertion #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion internal/testutil/testutil_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,10 @@ var _ = Describe("WaitForVMRunning", func() {
namespace = testutil.UniqueNamespace("wait-test")
err := testutil.EnsureTestNamespace(ctx, c, namespace)
Expect(err).NotTo(HaveOccurred())

// Warm the KubeVirt API discovery cache so timing assertions
// aren't skewed by first-call REST mapping overhead.
_ = testutil.WaitForVMRunning(ctx, c, "warmup", namespace, 1*time.Second)
})

AfterEach(func() {
Expand All @@ -166,7 +170,7 @@ var _ = Describe("WaitForVMRunning", func() {

Expect(err).To(HaveOccurred())
Expect(elapsed).To(BeNumerically(">=", 1*time.Second))
Expect(elapsed).To(BeNumerically("<", 3*time.Second))
Expect(elapsed).To(BeNumerically("<", 5*time.Second))
})
})
})
Loading