feat(workloads): wire chaos workload params through WorkloadConfig.Params#77
Merged
Conversation
…rams Read mount, fill-percent, fill-sleep, release-sleep (chaos-disk), latency-ms, packet-loss-percent (chaos-network), and signal, interval, min-pid (chaos-process) from Config.Params with documented defaults, mirroring the tps workload pattern. Convert hardcoded script constants and systemd units to format-string templates. Remove ChaosNetworkWorkload Latency/PacketLoss struct fields in favor of param accessors. Add tests for default values, full custom overrides, and partial param maps across all three chaos workloads. Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
Complete annotated example covering every global setting, SSH field, audit option, and all nine workloads with their per-workload params. Each key includes its default value, equivalent env var, and CLI flag. Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrhillsman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
exe-prow-github-app
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read mount, fill-percent, fill-sleep, release-sleep (chaos-disk), latency-ms, packet-loss-percent (chaos-network), and signal, interval, min-pid (chaos-process) from Config.Params with documented defaults, mirroring the tps workload pattern. Convert hardcoded script constants and systemd units to format-string templates. Remove ChaosNetworkWorkload Latency/PacketLoss struct fields in favor of param accessors.
Add tests for default values, full custom overrides, and partial param maps across all three chaos workloads.
Create config.yaml.example configuration file with inline documentation.
Resolves #62 and #63