fix(audit): populate cluster_context and cleanup_mode, drop workload timestamps#79
Merged
Merged
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrhillsman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
exe-prow-github-app
Bot
added
the
approved
mrhillsman
force-pushed
the
fix/audit-schema-unused-columns
branch
from
May 23, 2026 05:38
6d58aa7 to
e5cf199
Compare
…timestamps Schema changes: - Remove unused started_at and completed_at columns from workload_details table - These columns were declared but never populated Populate audit_log.cluster_context: - Modify cluster.Connect to return (client, contextName, error) - Add ClusterContext field to config.Config (runtime-only) - Set cfg.ClusterContext after cluster connection in runE and cleanupE - Update StartExecution to insert cluster_context value - Context is set to "in-cluster" for service account auth, NULL for dry-run Populate audit_log.cleanup_mode: - Set cfg.CleanupMode in cleanupE based on flags before StartExecution - Values: "all" (no filter), "run-id" (specific run), "dry-run" (no deletion) - NULL for run commands Test coverage: - Add tests verifying cluster_context and cleanup_mode are recorded - Update existing tests for cluster.Connect signature change - All tests pass Documentation: - Update docs/audit-schema.md to reflect schema changes - Document cluster_context and cleanup_mode column meanings - Remove workload timestamp columns from ERD and table descriptions Resolves #64 Resolves #65 Resolves #66 Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
mrhillsman
force-pushed
the
fix/audit-schema-unused-columns
branch
from
May 23, 2026 05:47
e5cf199 to
388d7ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Schema changes:
Populate audit_log.cluster_context:
Populate audit_log.cleanup_mode:
Test coverage:
Documentation:
Resolves #64 Resolves #65 Resolves #66