fix(config): honor WorkloadConfig.Enabled field in orchestration#80
Merged
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrhillsman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
exe-prow-github-app
Bot
added
the
approved
Changes WorkloadConfig.Enabled from bool to *bool to distinguish between: - nil (field not set in YAML, defaults to enabled) - &true (explicitly enabled in YAML) - &false (explicitly disabled in YAML) Updates orchestration in cmd/virtwork/main.go runE to: - Skip workloads where Enabled is explicitly set to false - Record audit event when skipping disabled workloads - Log skip reason at INFO level Adds config.BoolPtr() helper for creating bool pointers in tests and code. Updates all tests to use config.BoolPtr(true) instead of bare true for Enabled field. Adds comprehensive test coverage for Enabled field behavior: - Tests for explicitly disabled workloads - Tests for explicitly enabled workloads - Tests for nil/default enabled behavior - Tests for BoolPtr helper function Updates docs/configuration.md to: - Document enabled field behavior and precedence - Show examples of enabled: true, enabled: false, and omitted - Explain audit event recording for skipped workloads Fixes #67 Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
mrhillsman
force-pushed
the
fix/honor-workload-enabled-field
branch
from
May 23, 2026 15:06
955b7ac to
604e195
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes WorkloadConfig.Enabled from bool to *bool to distinguish between:
Updates orchestration in cmd/virtwork/main.go runE to:
Adds config.BoolPtr() helper for creating bool pointers in tests and code.
Updates all tests to use config.BoolPtr(true) instead of bare true for Enabled field.
Adds comprehensive test coverage for Enabled field behavior:
Updates docs/configuration.md to:
Fixes #67
Signed-off-by: Melvin Hillsman mhillsma@redhat.com