fix(tps): return errors from file-size parser and add E2E coverage#84
Merged
Conversation
…lent fallback fileSizeBytes() and fileSizeMBCount() silently fell back to default values on parse failure, masking configuration errors. Extract a shared parseFileSize() that validates format (positive integer + K/M/G suffix) and return errors through buildServerUserdata/buildClientUserdata so invalid file-size params fail fast at the orchestration layer. Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
The tps workload server requires netperf and python3 but they were missing from the golden-image pre-install list, causing cloud-init to install them on every boot. Add both packages and verify netserver and python3 binaries are present. Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
Verify that the tps workload deploys both server and client VMs, creates the three-port service (netperf-ctrl, netperf-data, http-data), and cleans up all resources. Covers the multi-VM deployment path that was previously untested end-to-end. Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrhillsman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
exe-prow-github-app
Bot
added
the
approved
Clarify that file-size must be a positive integer followed by K, M, or G and that decimal values and binary suffixes are not supported. Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fileSizeBytes()andfileSizeMBCount()with explicit error returns, so invalidfile-sizeparams (e.g.1.5G,2GB,garbage) fail fast instead of silently using defaultsparseFileSize()validator: positive integer + K/M/G suffixfile-sizeformat constraint in configuration referenceResolves #71
Resolves #73