fix(config): wire --ssh-key-file flag into resolveSSHKeys#94
Merged
Conversation
Add tests that verify: - reading a public key from --ssh-key-file - reading multiple --ssh-key-file flags - merging --ssh-key and --ssh-key-file - error on nonexistent --ssh-key-file path All tests currently fail because the flag is not registered in BindFlags() and resolveSSHKeys() does not read files. resolveSSHKeys now reads public key files from --ssh-key-file paths and merges them with inline --ssh-key values. Both CLI flag sources share highest priority, followed by VIRTWORK_SSH_AUTHORIZED_KEYS env var, then YAML config. Returns an error if a specified key file cannot be read, rather than silently producing VMs without SSH access. Also registers --ssh-key-file in BindFlags for test coverage. Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
Apply filepath.Clean to normalize user-supplied key file paths and add nolint directive — this is a CLI tool where the user intentionally specifies the file path. Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrhillsman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
exe-prow-github-app
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests that verify:
All tests currently fail because the flag is not registered in BindFlags() and resolveSSHKeys() does not read files.
resolveSSHKeys now reads public key files from --ssh-key-file paths and merges them with inline --ssh-key values. Both CLI flag sources share highest priority, followed by VIRTWORK_SSH_AUTHORIZED_KEYS env var, then YAML config.
Returns an error if a specified key file cannot be read, rather than silently producing VMs without SSH access.
Also registers --ssh-key-file in BindFlags for test coverage.
Resolves #93