fix(config): align --disk-size flag name with production CLI#96
Merged
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrhillsman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
exe-prow-github-app
Bot
added
the
approved
mrhillsman
force-pushed
the
fix/disk-size-flag-mismatch
branch
from
May 26, 2026 00:43
e1507bd to
efad0c3
Compare
The CLI registered --disk-size but the Viper key was data-disk-size, causing the flag to be silently ignored. Rename the Viper key to disk-size so flag name, Viper key, and YAML key all match, allowing bindFlagIfSet to work directly. Breaking: env var changes from VIRTWORK_DATA_DISK_SIZE to VIRTWORK_DISK_SIZE; YAML key changes from data-disk-size to disk-size. Fixes #95 Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
mrhillsman
force-pushed
the
fix/disk-size-flag-mismatch
branch
from
May 26, 2026 00:51
efad0c3 to
906b507
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BindFlags registered data-disk-size but production main.go registers disk-size, causing the flag to be silently ignored. Rename the flag to disk-size and map it explicitly to the data-disk-size Viper key, matching the pattern used by --no-wait ? wait-for-ready.
add failing tests for --disk-size flag binding
virtwork registers --disk-size but LoadConfig binds data-disk-size, causing the flag to be silently ignored. These tests verify the full priority chain for the disk-size flag.
Fixes #95