fix(vm): replace resource.MustParse with ParseQuantity to prevent panics#98
Merged
Conversation
MustParse panics on invalid input, which crashes the process when users provide malformed memory or disk-size values. Use ParseQuantity and propagate errors to callers instead. Resolves #97 Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
…Templates Update all callers of BuildVMSpec and DataVolumeTemplates to handle the (value, error) return pattern introduced in dfd2617. This includes production code (cmd/virtwork/main.go, workload implementations), unit tests, and integration tests. Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
Replace terse "parsing memory" / "parsing disk size" prefixes with messages that show valid examples (e.g. 512Mi, 2Gi), so users don't have to decipher the Kubernetes quantity regex. Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrhillsman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
exe-prow-github-app
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resource.MustParse()panics on invalid inputinternal/vm/vm.go
resource.MustParse(opts.Memory)will panic (not error) if a user passes an invalid memory string like2Ginstead of2GiA CLI tool should never panic on bad user input
Resolves #97