[Minor] ChartMimic: Add exception guard, 600s timeout, chart_type 120s, log to debug#1465
Open
TianhaoLiang2000 wants to merge 1 commit intoopen-compass:mainfrom
Open
Conversation
Contributor
TianhaoLiang2000
commented
Mar 4, 2026
- judge_one_item() wraps _judge_one_item() in try-except; returns zero score dict on failure
- Original logic moved to _judge_one_item() with @timeout(600, use_signals=False)
- chart_type_evaluator timeout raised from 60s to 120s
- logger.info -> logger.debug for per-item score logs to reduce noise
… 120s, log to debug - judge_one_item() wraps _judge_one_item() in try-except; returns zero score dict on failure - Original logic moved to _judge_one_item() with @timeout(600, use_signals=False) - chart_type_evaluator timeout raised from 60s to 120s - logger.info -> logger.debug for per-item score logs to reduce noise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.