import/export Taxonomy API functions - #1
Closed
ChrisChV wants to merge 7 commits into
Closed
Conversation
ChrisChV
force-pushed
the
chris/taxonomy-import-export
branch
from
June 21, 2023 18:29
c0e5a48 to
ebda011
Compare
3 tasks
pomegranited
suggested changes
Jun 22, 2023
pomegranited
left a comment
pomegranited
left a comment
There was a problem hiding this comment.
This is looking better, thank you @ChrisChV ! Couple more changes requested, but once they're resolved, this should be good to go.
| f"Invalid JSON format: Missing '{key}' on a tag ({tag})" | ||
| ) | ||
| ) | ||
| resync_tags() |
There was a problem hiding this comment.
I added an optional parameter to resync_tags which will speed up this call:
Suggested change
| resync_tags() | |
| resync_tags(ObjectTag.objects.filter(taxonomy=taxonomy)) |
You'll need to merge the latest changes from openedx#57 over here to use it though.
ChrisChV
force-pushed
the
chris/taxonomy-import-export
branch
from
June 22, 2023 20:55
ebda011 to
455e783
Compare
pomegranited
force-pushed
the
jill/taxonomy-api
branch
from
June 25, 2023 02:40
198bea7 to
1551cea
Compare
pomegranited
approved these changes
Jun 25, 2023
pomegranited
left a comment
pomegranited
left a comment
There was a problem hiding this comment.
@ChrisChV This branch looks great, thank you!
I've squashed and rebased openedx#57 and am hoping that will be merged tomorrow.. so I think you can wait until that's merged and resurrect openedx#58, moving these changes over there?
Sorry for all the changes on my branch.. it's hard to work in parallel like this, but was the best use of time I think.
👍
- I tested this by running the tests on my local machine and ensuring they cover all the code.
- I read through the code carefully and checked that it covers the required functionality.
-
I checked for accessibility issuesN/A - Includes documentation
- Commit structure follows OEP-0051
pomegranited
force-pushed
the
jill/taxonomy-api
branch
from
June 26, 2023 07:35
1551cea to
ac388bb
Compare
Also: * Adds compile-requirements make target and updates (without upgrading) the requirements, which pulled in some other requirements, since it's been a while since they were compiled. * Adds ddt as a test dependency. * Replaces the placeholder TagContent class, and squashes migrations down to a single file * use the openedx_learning.lib multi-collation char and text fields
Also: * Adds rules requirement and app settings to enable it * Adds mock to test requirements, so we can test system taxonomy rules * ADR: Clarifies that rules will be enforced in the views, not the model or APIs
Tests are failing in openedx on sqlite.
ChrisChV
force-pushed
the
chris/taxonomy-import-export
branch
from
June 27, 2023 21:50
a043b41 to
e5b1698
Compare
Member
Author
|
Closed in favor of openedx#64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements import_tags and export_tags functions
Supporting information
Temporal PR until openedx#57 will merged
Testing instructions