Skip to content

Content libraries permissions UI (WIP) - #11

Closed
bradenmacdonald wants to merge 4 commits into
content-libraries-permissionsfrom
content-libraries-permissions-ui
Closed

Content libraries permissions UI (WIP)#11
bradenmacdonald wants to merge 4 commits into
content-libraries-permissionsfrom
content-libraries-permissions-ui

Conversation

@bradenmacdonald

Copy link
Copy Markdown
Member

This adds a new settings page in studio's library view that can be used to assign roles to users of a content library.

Each user can be in one of three roles:

  • Admin: Can edit content and assign roles to users
  • Staff: Can edit content but not users
  • User: Can view content (and use it in their own courses) but cannot edit anything.

screen shot 2014-11-12 at 11 15 29 pm

@bradenmacdonald

Copy link
Copy Markdown
Member Author

Hey @marcotuts, do you guys have design mockup for how you want the user permissions editor screen to look for content libraries? Above you can see what I've implemented for now in this branch - three levels of permissions, and on each user there is a button to promote or demote. Please let me know what feedback you have, or if you have a better design that I could implement now.

@marcotuts

Copy link
Copy Markdown

@bradenmacdonald - This is a screen I will link to from the InvisionApp, but for now here it is directly. Let me know if you have any questions!
http://invis.io/3W1OU619Z

@marcotuts

Copy link
Copy Markdown

I tried to reuse all the existing patterns we have on the current Course Team page, while making sure that all the text is updated to reflect the Libraries use case, which it looks like you have done as well.

@bradenmacdonald
bradenmacdonald force-pushed the content-libraries-permissions-ui branch from b6c0679 to e90c793 Compare November 14, 2014 00:18
@bradenmacdonald

Copy link
Copy Markdown
Member Author

Thanks @marcotuts :) Updated version pushed. Screenshot:

screen shot 2014-11-13 at 4 19 10 pm

A few comments:

  • The existing "Manage Course Team" page uses gray for the "Remove admin" button, so the same styles are making the remove buttons gray on this page too, although that contradicts your mockup. Let me know what you want done.
  • Do we have to support narrow screens? Starting at ~1100px and getting narrower, the design starts to degrade a bit, and as we get down to a width of 950px, it starts to look like this, as there simply isn't enough room to keep all the elements on one line:
    screen shot 2014-11-13 at 4 22 13 pm
  • Any other changes you'd like?

@marcotuts

Copy link
Copy Markdown

@bradenmacdonald -Awesome!

Staying consistent with our existing patterns is great, so having the grey button is definitely the right thing to have done here.

The lack of responsiveness is definitely something that would be worth addressing if possible. Let's do this - I'm going to ask someone on the design team do a FED review and suggest possible patterns for handling responsiveness here. I see you've used flex grid, but we may want to change this in smaller screen sizes. I'll check in on the latest Studio patterns we've implemented and add a reviewer to this tomorrow.

Thanks for the quick response and update!

@bradenmacdonald
bradenmacdonald force-pushed the content-libraries-permissions branch from acbaddb to 9edecd1 Compare November 14, 2014 05:36
@bradenmacdonald
bradenmacdonald force-pushed the content-libraries-permissions-ui branch from e90c793 to 3c048c2 Compare November 14, 2014 05:36
@bradenmacdonald

Copy link
Copy Markdown
Member Author

I have rebased this as content_libraries/5-permissions and will close this PR for now. Soon we will open an upstream PR to get the rebased version merged into the content-libraries feature branch.

@bradenmacdonald
bradenmacdonald deleted the content-libraries-permissions-ui branch November 28, 2014 03:22
pomegranited added a commit that referenced this pull request Sep 12, 2018
Adds the Studio version of the compiled static JS translation files
pomegranited pushed a commit that referenced this pull request Sep 2, 2019
SE-1155 Allows unicode usernames to be used in CCX enrollments and reports.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants