Content libraries UI updates - #14
Conversation
This changes the style of the inactive libraries/courses tab when hovering. Only the active tab on the dashboard page gets the blue underline. When hovering over an inactive tab, the color of the text changes, but the underline does not appear.
7a0f468 to
8eb8f7b
Compare
There was a problem hiding this comment.
@mtyaka "This cannot be changed" => not true anymore, since this can still be changed from the Edit menu right?
Btw I've confirmed that we want to keep it editable in that menu for now. Btw I don't see that edit menu on the sandbox instance that runs https://github.com/edx/edx-platform/pull/6046 -- http://content-libraries.sandbox.opencraft.com:18010 Did I miss something or is this menu dependent on another PR?
There was a problem hiding this comment.
@antoviaque Nice catch, I'll remove "This cannot be changed". I'm have no idea why the button doesn't show up on that instance.
There was a problem hiding this comment.
@mtyaka Sounds good, thanks!
@e-kolpakov Cf above - do you know why the "Edit" doesn't show on the sandbox based on https://github.com/edx/edx-platform/pull/6046 ?
There was a problem hiding this comment.
@antoviaque because @bradenmacdonald removed edit button from content_libraries/2-studio-lib-support for some reason. I'm not sure though if it was planned to be added later, or a mistake.
There was a problem hiding this comment.
@e-kolpakov Ok, thanks for the info. Unless they block about this in the upstream PR, let's wait until @bradenmacdonald comments on this when he's back then.
|
Some of the changes from this PR were already cherry-picked into |
Update requirements to pull in edx-olive-oc version of ORA2.
3 participants
display_namelibrary field non-editable.