Implement Pagination for Content libraries - #18
Merged
Conversation
Kelketek
commented
Dec 4, 2014
Member
- Background: This PR provides pagination for content Libraries in the container view, when displaying the blocks contained in the library.
- Jira tickets: Implements SOL-4
- Discussions: Architecture discussed extensively on the wiki and in meetings, then the revised proposal was presented to the Arch Council on Oct. 21 and given thumbs up.
- Dependencies: https://github.com/edx/edx-platform/pull/6046 (merged, in feature branch https://github.com/edx/edx-platform/commits/content-libraries)
- Sandbox URL: TBD
- Internal code reviews PRs: Content libraries paging #9 Implement Pagination for Content libraries #18
- Partner information: 3rd party-hosted open edX instance, for an edX solutions client.
There was a problem hiding this comment.
Most likely it would make sense to log actual error with log.exception(message). Also, upstream reviewers (sarina mostly) often point out that logging is more efficient using log("something with %old_style format parameters", parameter1, parameter2, ...)
Kelketek
force-pushed
the
content_libraries/4-pagination
branch
2 times, most recently
from
December 5, 2014 19:59
e99254f to
363211b
Compare
Kelketek
force-pushed
the
content_libraries/4-pagination
branch
from
December 8, 2014 23:06
5d75d5f to
c940f16
Compare
bradenmacdonald
force-pushed
the
content-libraries
branch
2 times, most recently
from
December 10, 2014 06:59
c87b2ac to
72e0c2c
Compare
Kelketek
force-pushed
the
content_libraries/4-pagination
branch
3 times, most recently
from
December 15, 2014 17:35
b34bf43 to
bdc7126
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.