Skip to content

Implement Pagination for Content libraries - #18

Merged
Kelketek merged 0 commit into
content-librariesfrom
content_libraries/4-pagination
Dec 23, 2014
Merged

Implement Pagination for Content libraries#18
Kelketek merged 0 commit into
content-librariesfrom
content_libraries/4-pagination

Conversation

@Kelketek

@Kelketek Kelketek commented Dec 4, 2014

Copy link
Copy Markdown
Member

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most likely it would make sense to log actual error with log.exception(message). Also, upstream reviewers (sarina mostly) often point out that logging is more efficient using log("something with %old_style format parameters", parameter1, parameter2, ...)

@Kelketek
Kelketek force-pushed the content_libraries/4-pagination branch 2 times, most recently from e99254f to 363211b Compare December 5, 2014 19:59
@Kelketek
Kelketek force-pushed the content_libraries/4-pagination branch from 5d75d5f to c940f16 Compare December 8, 2014 23:06
@bradenmacdonald
bradenmacdonald force-pushed the content-libraries branch 2 times, most recently from c87b2ac to 72e0c2c Compare December 10, 2014 06:59
@Kelketek
Kelketek force-pushed the content_libraries/4-pagination branch 3 times, most recently from b34bf43 to bdc7126 Compare December 15, 2014 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants