Content libraries UI Updates - #19
Closed
Kelketek wants to merge 10 commits into
Closed
Conversation
Kelketek
commented
Dec 5, 2014
Kelketek
commented
Member
- Background: This PR contains UI Updates for the content-libraries studio view and content block.
- Jira tickets: Implements SOL-80, SOL-7
- Discussions: Architecture discussed extensively on the wiki and in meetings, then the revised proposal was presented to the Arch Council on Oct. 21 and given thumbs up.
- Dependencies: https://github.com/edx/edx-platform/pull/6155
- Sandbox URL: TBD
- Internal code reviews PRs: Content libraries UI Updates #19
- Partner information: 3rd party-hosted open edX instance, for an edX solutions client.
There was a problem hiding this comment.
@Kelketek there's a way to do a redirect in urls.py: http://stackoverflow.com/questions/15706489/redirect-to-named-url-pattern-directly-from-urls-py-in-django
So it might make sense to add a route like /course/?$ that only perform redirect, than get rid of that if-else block in course.py
|
👍 There are some improvements you might want to add (optionally):
Neither of this is a show-stopper, of course. |
bradenmacdonald
force-pushed
the
content_libraries/3-library-course-block
branch
from
December 10, 2014 06:08
e508ae4 to
9bac8cb
Compare
bradenmacdonald
force-pushed
the
content_libraries/3-library-course-block
branch
2 times, most recently
from
December 10, 2014 07:26
7afa32e to
f85f962
Compare
Member
|
@Kelketek FYI, per requests from reviewers on PR 6155 I cherry-picked three of these commits and included them in that PR:
... so when you rebase, you'll probably want to just delete those commits from this branch. |
bradenmacdonald
force-pushed
the
content_libraries/3-library-course-block
branch
2 times, most recently
from
December 17, 2014 20:15
ad29a90 to
03a9ebb
Compare
mtyaka
force-pushed
the
content_libraries/11-UI-updates
branch
3 times, most recently
from
December 22, 2014 07:57
58cd4e5 to
a0ec17e
Compare
Member
Author
|
As @mtyaka is now working on the rebase for this, and I've been assigned to make sure that's all good, I have reviewed it and give it a 👍 :) |
bradenmacdonald
force-pushed
the
content_libraries/3-library-course-block
branch
from
December 23, 2014 19:31
82b7bb8 to
0cc3b33
Compare
…ibrary-course-block LibraryContent - Display content from a library in a course (SOL-5, SOL-6, SOL-7, SOL-8, SOL-117)
This changes the style of the inactive libraries/courses tab when hovering. Only the active tab on the dashboard page gets the blue underline. When hovering over an inactive tab, the color of the text changes, but the underline does not appear.
Most of the updates are related to the My Courses -> Studio Home change.
mtyaka
force-pushed
the
content_libraries/11-UI-updates
branch
from
December 29, 2014 14:25
ec07431 to
7df8664
Compare
Member
|
Opened https://github.com/edx/edx-platform/pull/6388, closing this one. |
clemente
pushed a commit
that referenced
this pull request
Nov 1, 2020
Compile using:
django-admin.py compilemessages -v0
./manage.py lms compilejsi18n --settings=devstack
./manage.py cms compilejsi18n --settings=devstack
* Adds "Answers are displayed within the problem"
* Updates "{earned}/{possible} points (graded)" and "...(ungraded)"
* Updates buttons on Support/Help pop-up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.