Skip to content

Remove Discussion and Advanced Modules from Content Libraries - #20

Closed
Kelketek wants to merge 2 commits into
content-librariesfrom
content_libraries/12-remove-discussion
Closed

Remove Discussion and Advanced Modules from Content Libraries#20
Kelketek wants to merge 2 commits into
content-librariesfrom
content_libraries/12-remove-discussion

Conversation

@Kelketek

@Kelketek Kelketek commented Dec 5, 2014

Copy link
Copy Markdown
Member
  • Background: This PR removes the ability to add Advanced or Discussion modules to a content library, restricting the number of supported components to start with.
  • Jira tickets: Implements SOL-120
  • Discussions: Architecture discussed extensively on the wiki and in meetings, then the revised proposal was presented to the Arch Council on Oct. 21 and given thumbs up.
  • Dependencies: https://github.com/edx/edx-platform/pull/6046 (merged, in feature branch https://github.com/edx/edx-platform/commits/content-libraries)
  • Sandbox URL: TBD
  • Internal code reviews PRs: (This)
  • Partner information: 3rd party-hosted open edX instance, for an edX solutions client.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kelketek Might want adding discussion-forum to prevent adding discussion XBlock. Not sure if it's really needed though. What was the reason behind disabling discussion XModule?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@e-kolpakov Don't know, the issue on Jira just says to do it, so I did. Disabling discussion-forum shouldn't be needed, since it's an advanced component and advanced components won't be used.

@e-kolpakov

Copy link
Copy Markdown

👍 with minor note.

@e-kolpakov

Copy link
Copy Markdown

One more thing - it might make sense to add python for get_component_templates. Bok choy test are required, but they are so sloooooow, so adding faster tests would benefit development cycle. If it's possible to add them not refactoring the whole thing into something completely different.

@Kelketek
Kelketek force-pushed the content_libraries/12-remove-discussion branch from d98d0d6 to 48e57a1 Compare December 8, 2014 16:42
@Kelketek

Kelketek commented Dec 8, 2014

Copy link
Copy Markdown
Member Author

@e-kolpakov Added a python test. Getting this upstream now.

@Kelketek
Kelketek force-pushed the content_libraries/12-remove-discussion branch from 48e57a1 to 8b3a9aa Compare December 11, 2014 22:21
@Kelketek
Kelketek force-pushed the content_libraries/12-remove-discussion branch from 8b3a9aa to 2e8f1df Compare December 15, 2014 13:16
@e-kolpakov

Copy link
Copy Markdown

@Kelketek do we still need this PR?

@Kelketek Kelketek closed this May 15, 2015
@Kelketek
Kelketek deleted the content_libraries/12-remove-discussion branch May 15, 2015 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants