Remove Discussion and Advanced Modules from Content Libraries - #20
Remove Discussion and Advanced Modules from Content Libraries#20Kelketek wants to merge 2 commits into
Conversation
Kelketek
commented
Dec 5, 2014
- Background: This PR removes the ability to add Advanced or Discussion modules to a content library, restricting the number of supported components to start with.
- Jira tickets: Implements SOL-120
- Discussions: Architecture discussed extensively on the wiki and in meetings, then the revised proposal was presented to the Arch Council on Oct. 21 and given thumbs up.
- Dependencies: https://github.com/edx/edx-platform/pull/6046 (merged, in feature branch https://github.com/edx/edx-platform/commits/content-libraries)
- Sandbox URL: TBD
- Internal code reviews PRs: (This)
- Partner information: 3rd party-hosted open edX instance, for an edX solutions client.
There was a problem hiding this comment.
@Kelketek Might want adding discussion-forum to prevent adding discussion XBlock. Not sure if it's really needed though. What was the reason behind disabling discussion XModule?
There was a problem hiding this comment.
@e-kolpakov Don't know, the issue on Jira just says to do it, so I did. Disabling discussion-forum shouldn't be needed, since it's an advanced component and advanced components won't be used.
|
👍 with minor note. |
|
One more thing - it might make sense to add python for |
d98d0d6 to
48e57a1
Compare
|
@e-kolpakov Added a python test. Getting this upstream now. |
b7c340b to
c87b2ac
Compare
SOL-1, SOL-2, SOL-3
c87b2ac to
72e0c2c
Compare
48e57a1 to
8b3a9aa
Compare
8b3a9aa to
2e8f1df
Compare
72e0c2c to
fcc2045
Compare
16809dd to
76d3f35
Compare
a622c71 to
134a75b
Compare
|
@Kelketek do we still need this PR? |