SE-1908 Fix for autoadvance issue with hls videos - #202
Merged
pkulkark merged 2 commits intoDec 16, 2019
Merged
Conversation
pomegranited
approved these changes
Dec 16, 2019
pomegranited
left a comment
pomegranited
left a comment
There was a problem hiding this comment.
@pkulkark 👍 once nit is fixed
- I tested this on my devstack as described by the PR description.
- I read through the code.
- I checked for accessibility issues
-
Includes documentationN/A, bugfix -
I made sure any change in configuration variables is reflected in the correspondingN/A
client'sconfiguration-securerepository.
| this.hls = new HLS({autoStartLoad: true}); | ||
| } else { | ||
| this.hls = new HLS({autoStartLoad: false}); | ||
| } |
There was a problem hiding this comment.
nit: please fix the spacing on this change to use 4 spaces instead of tabs.
Member
Author
There was a problem hiding this comment.
Oops! Sorry about that. My vim editor had some weird feature enabled. Corrected it now.
pkulkark
force-pushed
the
pooja/fix-autoadvance-issue-with-hls-videos
branch
from
December 16, 2019 06:02
48a7902 to
a68d169
Compare
Kelketek
pushed a commit
that referenced
this pull request
Sep 8, 2020
Sustaining/security fixes 5 (cherry picked from commit f87e1d2)
toxinu
pushed a commit
that referenced
this pull request
Sep 18, 2020
Sustaining/security fixes 5 (cherry picked from commit f87e1d2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue with autoadvance noted on cloudera courses which are HLS videos.
Upstream PR: #22539
Testing Instructions:
Reviewers: