SE-3243 Use original get_html for AboutBlock - #258
Merged
samuelallan72 merged 1 commit intoSep 28, 2020
Merged
Conversation
This is required to stop get_course_about_section html content from using the edxnotes version of get_html, which injects the edxnotes html into it. We don't want this injected into the html here, because these are snippets meant to be displayed in original form on the course about page.
|
Since it is a back port that I have already tested, let's merge it 👍🏻 |
toxinu
approved these changes
Sep 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to stop get_course_about_section
html content from using the edxnotes version of
get_html, which injects the edxnotes html into it.
We don't want this injected into the html here,
because these are snippets meant to be displayed
in original form on the course about page.
See https://github.com/edx/edx-platform/pull/24930 for more details and test instructions. This PR simply backports that to our juniper.3 release branch.