[BB-3057] Use BytesIO as unicodecsv expects a bytestream, not unicode - #259
Merged
lgp171188 merged 1 commit intoSep 28, 2020
Conversation
This fixes the error thrown when trying to download the list of all users, staff and instructors from the Sysadmin dashboard
farhaanbukhsh
approved these changes
Sep 25, 2020
Member
There was a problem hiding this comment.
👍
Have tested this and this works fine, I could reproduce the issues and verify the fix.
- I tested this: Verify the branch on devstack and saw it was giving the issue, used this branch and I could see it fixing it. Tried downloading file and verified the data
- I read through the code
-
I checked for accessibility issues -
Includes documentationDoesn't require the documentation -
I made sure any change in configuration variables is reflected in the corresponding client'sconfiguration-securerepository.
Agrendalath
deleted the
guruprasad/BB-3057-sysadmin-dashboard-csv-download-fix
branch
November 16, 2020 18:42
Agrendalath
pushed a commit
that referenced
this pull request
Nov 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the error thrown when trying to download the list of all
users, staff and instructors from the Sysadmin dashboard
Reference: unicodecsv README file
Testing instructions:
Sysadmin dashboardby setting theENABLE_SYSADMIN_DASHBOARDfeature flag totruein/edx/etc/lms.ymland restart the LMS.Userssection, try to download a list of all the users in CSV file format. An exception complainingTypeError: string argument expected, got 'bytes'will be thrown.Staffing and enrollmentsection, try downloading the staff and instructor list in a CSV file format. A similar exception will be thrown.