[SE-3401] Webpack Hashes to use Md5Hash Plugin to be consistent among multiple instances - #268
Closed
nizarmah wants to merge 2 commits into
Conversation
2 tasks
2 tasks
Author
|
Closed pull request because commit |
nizarmah
deleted the
nizar/temporary_fix_multiple_instances_webpack_juniper_3_backport
branch
October 7, 2020 12:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a small bug that started happening in Juniper related to webpack's cached files, where the hashes were not consistent on different machines and would change on every assets update. Accordingly, this caused 404 errors with multiple instances and load balancers, which made the Studio and LMS unusable.
Some examples of the Studio and LMS being unusable:
In order to solve this issue, I've created 2 different pull requests.
The reason for a temporary fix is because a long term one might have a longer review process than desired. So the issue would be fixed in the meantime, but a better fix would be merged later on.
JIRA tickets: SE-3401
Sandbox URL:
Testing instructions:
commons.js.ls /edx/var/edxapp/staticfiles/studio/bundles/ | grep -i commonsis the same among the different instances./edx/var/edxapp/staticfiles/studio/bundles/and/edx/var/edxapp/staticfiles/bundles/between both App Servers and make sure they have the same filename (including hashes)./edx/var/edxapp/staticfiles/studio/bundles/and/edx/var/edxapp/staticfiles/bundles/between app servers with old instances (without the fix) and new ones (with the fix) and make sure everything is similar/acting normal.Reviewers