[SE-3816] Adds waffle switch to enable third party auth email association - #304
Merged
nizarmah merged 3 commits intoDec 28, 2020
Conversation
nizarmah
force-pushed
the
nizar/tpa_associate_by_email_waffle_switch_backport
branch
from
December 23, 2020 12:53
4d751cb to
d3a4f1b
Compare
nizarmah
force-pushed
the
nizar/tpa_associate_by_email_waffle_switch_backport
branch
3 times, most recently
from
December 26, 2020 03:13
e4a21bb to
ee111ae
Compare
(cherry picked from commit 914410a47b50933e5a92e2e77e0dbc85ff405cce)
nizarmah
force-pushed
the
nizar/tpa_associate_by_email_waffle_switch_backport
branch
from
December 26, 2020 03:23
ee111ae to
ff8a593
Compare
(cherry picked from commit 2f727bab3d27d52907a119e2f6366247c79c30af)
…ne method (cherry picked from commit 03a6882f79fec104aae6a2a2c889e0452638d400)
|
👍 🎉
|
gabor-boros
approved these changes
Dec 28, 2020
gabor-boros
reviewed
Dec 28, 2020
|
|
||
| @partial.partial | ||
| def associate_by_email_if_login_api(auth_entry, backend, details, user, current_partial=None, *args, **kwargs): | ||
| def associate_user_by_email(auth_entry, backend, details, user, current_partial=None, *args, **kwargs): |
There was a problem hiding this comment.
Don't we want to apply edx@0219edd as well?
There was a problem hiding this comment.
Hm, since we will upgrade python when we upgrade edx-platform (I guess), this is not an issue then.
gabor-boros
requested changes
Dec 28, 2020
gabor-boros
left a comment
gabor-boros
left a comment
There was a problem hiding this comment.
Please see the comment about the "missing" commit
gabor-boros
approved these changes
Dec 28, 2020
nizarmah
deleted the
nizar/tpa_associate_by_email_waffle_switch_backport
branch
December 28, 2020 18:28
viadanna
pushed a commit
that referenced
this pull request
Mar 26, 2021
nizarmah
pushed a commit
that referenced
this pull request
Dec 14, 2021
from the edx-sga release notes at https://github.com/mitodl/edx-sga/blob/master/RELEASE.rst - Update license classifier (#312) - Update license text to match pypi's acceptable list (#310) - Upgrade django to 3.2 LTS (#304)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, in the edX platform, if you try to login with an SSO account using the login form, a username is generated for you based on the email that is used with the SSO provider.
The username is generated using the pipeline
third_party_auth.pipeline.get_username.If the username already exists in the platform, you run into a small conflict which sends you back to the login form and requests the following:
It basically requests that you link your edX account and your SSO account.
However, sometimes we would want the edX account and SSO account to be associated by email. There's already a special pipeline available in the platform for that,
third_party_auth.pipeline.associate_by_email_if_login_api. Sadly, however, it is only available for a certain entry method of authentication, calledlogin_api.So in order to start associating the edX account and SSO account by email, this pull request adds a waffle switch.
JIRA tickets: SE-3816
Upstream Pull Request: https://github.com/edx/edx-platform/pull/25935
Testing instructions:
Reviewers