Skip to content

Revert "[SE-3381] Allows adding new tinymce plugins through platform configuration" - #306

Merged
nizarmah merged 1 commit into
opencraft-release/juniper.3from
revert-295-nizar/tinymce-easy-plugin-modification-backport
Jan 6, 2021
Merged

Revert "[SE-3381] Allows adding new tinymce plugins through platform configuration"#306
nizarmah merged 1 commit into
opencraft-release/juniper.3from
revert-295-nizar/tinymce-easy-plugin-modification-backport

Conversation

@nizarmah

@nizarmah nizarmah commented Jan 6, 2021

Copy link
Copy Markdown

Reverts #295

The reason behind the revert is that with multiple app servers, the TinyMCE object in the JavaScript code doesn't get sorted by key. This is a huge problem because the changes being upstreamed are already being sorted by key...

So it seems like there's a specific backport that is missing, which should be done before merging this change.

Here's what I'm talking about:

  • File 1:
                           var d = {
                              TINYMCE_ADDITIONAL_PLUGINS: [{
                                 toolbar: !0,
                                 extra_settings: {
                                    linktypes: ["download", "offer"],
                                    orientations: ["Vertical", "Horizontal"],
                                    filetypes: ["PDF", "zip", "Video", "Design"],
                                    styles: ["Primary", "Normal", "Secondary"]
                                 },
                                 name: "adsklink"
                              }]
                           }.TINYMCE_ADDITIONAL_PLUGINS;
  • File 2:
                           var d = {
                              TINYMCE_ADDITIONAL_PLUGINS: [{
                                 toolbar: !0,
                                 name: "adsklink",
                                 extra_settings: {
                                    linktypes: ["download", "offer"],
                                    orientations: ["Vertical", "Horizontal"],
                                    filetypes: ["PDF", "zip", "Video", "Design"],
                                    styles: ["Primary", "Normal", "Secondary"]
                                 }
                              }]
                           }.TINYMCE_ADDITIONAL_PLUGINS;

@nizarmah
nizarmah merged commit 023db6c into opencraft-release/juniper.3 Jan 6, 2021
@nizarmah
nizarmah deleted the revert-295-nizar/tinymce-easy-plugin-modification-backport branch January 6, 2021 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant