[BB-4649] Fix duplicate Arabic month in course start date - #385
Merged
shimulch merged 1 commit intoAug 17, 2021
Conversation
|
👍🏽
|
alfredchavez
self-requested a review
August 11, 2021 17:58
alfredchavez
approved these changes
Aug 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes duplicate Arabic month issue reported by NELP. The issue is due to our dependency on an old version of Moment JS. Relevant issues can be found on Moment JS Github Issues.
Supporting information
https://tasks.opencraft.com/browse/BB-4649
Screenshots
Before this PR -
After this PR -
Testing instructions
arfrom/update_langin the LMSDeadline
None
Other information
Reviewer