Fix: Allow delete course content in Studio only for admin users - #440
Merged
joidegn merged 3 commits intoNov 17, 2021
Conversation
joidegn
added a commit
that referenced
this pull request
Nov 17, 2021
* Fix PREVENT_STAFF_STRUCTURE_DELETION flag for ajax requests * Add testcase for CourseCreatorRole
xitij2000
pushed a commit
that referenced
this pull request
Nov 22, 2021
* Fix PREVENT_STAFF_STRUCTURE_DELETION flag for ajax requests * Add testcase for CourseCreatorRole
bradenmacdonald
deleted the
joidegn/fix-se-4482-allow-delete-in-studio-only-for-admin-koa.3
branch
January 12, 2022 02:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a couple of minor issues with SE-4482. Specifically the delete icon would reappear when the visibility of a section was changed.
Supporting information
JIRA Ticket: SE-4482
Testing instructions
Login on
https://studio.pr440.sandbox.stage.opencraft.hosting/.Enable PREVENT_STAFF_STRUCTURE_DELETION waffle flag from
https://studio.pr440.sandbox.stage.opencraft.hosting/adminGo to the setting > Course team of the Demonstration Course
Add
verified@example.comas the staff for the courseLogin from the
verified@example.comon the studio pageverified@example.comshould not be able to see the delete button on the course outline page.Change the visibility of a section like here
The delete button should not reappear
Additionally: confirm whether the business logic is correct for the course creator, instructor and staff roles.
Reviewers